winpty returns the wrong pid

[javruben]

winpty returns the wrong pid

[rprichard]

Here's the quoted line 155 of src/win/pty.cc:

marshal->Set(String::New("pid"), Number::New((int)pc->controlPipe));

It looks like it's setting the pty.js's "pid" value to the Win32 named pipe HANDLE value, which is not a process ID. It looks like pty.js wants/needs to assign a "pid" to the terminal before the child process has actually started, so instead of using the actual child process PID, it uses this magic value instead.

In my copy of winpty, there's a winpty_get_process_id function that returns the PID of the child process. However, in src/win/pty.cc, you wouldn't be able to call winpty_get_process_id in PtyOpen -- you'd have to call it in PtyStartProcess, after calling winpty_start_process.

(Also: I'm not sure it matters, but casting a HANDLE to an int isn't going to be reliable on 64-bit Windows.)

[rprichard]

It's not clear what happened with this issue. I can reopen if there's still something wrong.

FWIW, my understanding is that pty.js's Windows support isn't currently working, and it also uses a forked version of winpty. I'm planning on changing the winpty API soon-ish, which should make integrating node.js and winpty much easier.