Certificate recognition fails with dashed domain

[rroemhild]

Certificate recognition fails with dashed domain

[rroemhild]

Hi, this should be fixed in 563e57a and on docker hub :latest. Just replace dashes with underscores like the dots, i.E EJABBERD_SSLCERT_WWW_EXAMPLE_DOMAIN_COM for www.example-domain.com.

[RikuXan]

Unfortunately, it seems that there is another error, that prevents dashed domains from working. I tried it with underscores instead of the dashes with your latest version and it did recognize it correctly and jumped into the write_file_from_env() function as I could see the output in my log, however the generated certificate (/opt/ejabberd/ssl/example-domain.com.pem) did not contain the certificate data, but rather the path that I set the env variable EJABBERD_SSLCERT_WWW_EXAMPLE_DOMAIN_COM to.

I'm not sure whether or not this worked at some point, I'm getting an error though.
I think changing the echo in scripts/pre/01_write_certifiates_from_env.sh line 17 to a cat would fix this.

[rroemhild]

The environment variables for passing sslcerts to the container should include the cert & key and not a path to a local file. The script runs in container on startup an can not look outside of the container. But you can mount a local ssl directory into the container with your ssl certificates.

In example with docker-compose.yml:

ejabberd:                                                                      
  image: rroemhild/ejabberd
  ports:                                                                       
    - 5222:5222                                                                
    - 5269:5269                                                                
    - 5280:5280                                                                
  environment:                                                                 
    - ERLANG_NODE=localhost                                                    
    - XMPP_DOMAIN=example-domain.com                                              
    - [email protected]                                   
    - [email protected] :password4321                          
    - EJABBERD_AUTH_METHOD=internal                                            
    - "EJABBERD_SSLCERT_EXAMPLE_DOMAIN_COM=-----BEGIN CERTIFICATE-----                                                                           
MIIFAzCCAuugAwIBAgIJAJoO+f1lEf0rMA0GCSqGSIb3DQEBCwUAMBgxFjAUBgNV               
BAMMDWxvY2FsLWhvc3QuZGUwHhcNMTYwNTE3MjAzNjI5WhcNMTcwNTE3MjAzNjI5               
WjAYMRYwFAYDVQQDDA1sb2NhbC1ob3N0LmRlMIICIjANBgkqhkiG9w0BAQEFAAOC               
...                    
-----END CERTIFICATE-----                                                      
-----BEGIN PRIVATE KEY-----                                                    
MIIJRAIBADANBgkqhkiG9w0BAQEFAASCCS4wggkqAgEAAoICAQCcCPEU+PuD+zyk               
xN4icj9LNpzWZnckYbiYG/94IQCv7Uj/H0j6vH5BTMwSJeppjT0neVgrdDPYWrCb               
...
-----END PRIVATE KEY-----"

[RikuXan]

Ah ok, then I misunderstood how it is supposed to work. I mounted a volume on a local directory and wrote the path to this file in the variable. All good then, thank you!