Giter Site home page Giter Site logo

zero value for zerolog.Logger about zerolog HOT 5 CLOSED

rs avatar rs commented on July 28, 2024
zero value for zerolog.Logger

from zerolog.

Comments (5)

bazuker avatar bazuker commented on July 28, 2024

@soulne4ny It does not seem like you initialized the logger.
Try something like this

package main

import (
	"github.com/rs/zerolog"
)

func main() {
	log := zerolog.New(os.Stdout).With().Timestamp().Logger()
	log.Info().Msg("crash")
}

from zerolog.

toravir avatar toravir commented on July 28, 2024

@oxygenD Do you think it is ok to change methods like Info(), Debug() etc to take pointer receivers ? So that one can check for nil pointers and not crash. That will also avoid compiler making a copy of the logger for the invocation.

from zerolog.

bazuker avatar bazuker commented on July 28, 2024

@toravir It's zero log, I guess if pointers were used instead, they would cause allocations which we are trying to avoid.

from zerolog.

toravir avatar toravir commented on July 28, 2024

@oxygenD i tried that and ran benchmark and i don't see an extra alloc - cpu usage isn't much different either. See:
With "(l * Logger) Info() *Event" :

BenchmarkInfo-8   	30000000	        39.2 ns/op	       0 B/op	       0 allocs/op

Without the change (base code):

BenchmarkInfo-8   	30000000	        41.8 ns/op	       0 B/op	       0 allocs/op

from zerolog.

rs avatar rs commented on July 28, 2024

Fixed by #18.

from zerolog.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.