With().Str(...).Logger() fails while With().Timestamp().Str(...).Logger() works

[rs]

With().Str(...).Logger() fails while With().Timestamp().Str(...).Logger() works

[toravir]

Here the fix for this error - will create a pr with this fix shortly..

index 83d1927..07a02b9 100644
--- a/log.go
+++ b/log.go
@@ -157,8 +157,10 @@ func (l Logger) Output(w io.Writer) Logger {
        l2 := New(w)
        l2.level = l.level
        l2.sampler = l.sampler
-       l2.context = make([]byte, len(l.context), cap(l.context))
-       copy(l2.context, l.context)
+       if l.context != nil {
+               l2.context = make([]byte, len(l.context), cap(l.context))
+               copy(l2.context, l.context)
+       }
        return l2
 }

[fiatjaf]

Smallest failing snippet:

fiatjaf@cantillon ~/c/test> cat x.go 
package main

import (
        "os"

        "github.com/rs/zerolog"
)

func main() {
        log := zerolog.New(os.Stderr).Output(zerolog.ConsoleWriter{Out: os.Stderr})

        bound := log.With().Str("x", "y").Logger()
        bound.Info().Msg("fails")

        bound = log.With().Timestamp().Str("x", "y").Logger()
        bound.Info().Msg("doesn't fail")
}
fiatjaf@cantillon ~/c/test> 
fiatjaf@cantillon ~/c/test> 
fiatjaf@cantillon ~/c/test> go run x.go 
zerolog: could not write event: invalid character 'x' looking for beginning of object key
string2017-09-25T16:53:07Z |INFO| doesn't fail x=y

[rs]

Fixed by 9a65e7c