New functions for improved composability

[pltr]

New functions for improved composability

[rs]

You have to be aware that this feature would not be portable to the binary serialization (cc @toravir). Other than that, I'm fine with the idea.

[pltr]

@rs it's probably not significantly different in that regard to RawJSON?

[rs]

Sure

[toravir]

@pltr - can't this be done using the LogObjectMarshaler() callback ?? imo, users should not be aware of the zerolog's internal buffer. RawJSON() api does not build the JSON piece by piece - so this is slightly different, but possible in cbor...

[pltr]

@toravir I'm not sure I follow. Given that price object above and the following call:

log.Info().Str("foo", "bar").Object("price", &price).Msg("Price is too high")

Would it be possible, assuming Price implements LogObjectMarshaler to result in

{"l":"info", "foo": "bar", "price": "$64.49", "m":"Price is too high"}

?
It seems MarshalZerologObject receives zerolog.Event object as the argument and Event doesn't seem to contain any methods that would allow the user to directly print into the current value. And even if it did it would leak the details significantly more than a generic JSOM buffer interface.

JSONAppendable isn't actually aware of anything, it's not even zerolog specific, it just expects a byte buffer and returns a filled buffer and that's about it. The only expectation there really is that the data it fills the buffer with is supposed to be a valid JSON value. Which means it's very generic in nature and can be used with any similar json serializer, so it's composable - you can stack a few of them together and they will just work. Of course in the case of zerolog it also means it's going to be zero copy/zero allocation, but but it's an implementation detail, however important.

[toravir]

Oh.. i know what you mean - the Object() api will make it look like ..,"price":{"value":"$64.49"},.. - it is not a clean log as "price":"$64.49"

Thinking about it... agree about JSONAppendable - it just adds its data as json value to the provided byte slice.

[toravir]

@pltr This is not exactly what you are looking for - but comes really close - toravir@8916864
Lemme know what you think..

[rs]

@pltr do you want to attempt a PR?