Giter Site home page Giter Site logo

Comments (5)

NiteshKant avatar NiteshKant commented on May 7, 2024

you mean specify that it is a 32 bit number?

from rsocket-java.

robertroeser avatar robertroeser commented on May 7, 2024

The ascii frame shows it's 32-bit which is an integer in java.

from rsocket-java.

yschimke avatar yschimke commented on May 7, 2024

So we had an issue with cpp (client) talking to java (server) because uint32 max is negative as a Java int. A went to the protocol doc to clarify, didn't get a clear answer there. So I checked the Java code, saw a long at first but after more digging found a (signed) int.

reactivesocket-core/src/main/java/io/reactivesocket/Frame.java:        public static long initialRequestN(final Frame frame) {
reactivesocket-core/src/main/java/io/reactivesocket/internal/frame/RequestFrameFlyweight.java:        final int initialRequestN,

from rsocket-java.

robertroeser avatar robertroeser commented on May 7, 2024

Ok I kind figured thats where this was going. I added a method internally on the RequestFrameFlyWeight to deal with this.

@tmontgomery
could we reserve the first bit so it's never negative?

from rsocket-java.

yschimke avatar yschimke commented on May 7, 2024

This looks consistent now, spec + code in RequestFrameFlyweight

from rsocket-java.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.