Comments (10)
It's missing from the docs, but normally, you fork the repo, push the changes to your forked repo, and send a PR upstream.
from rspec-core.
@pirj thanks, gonna try the proposed path
@JonRowe
I would also like to suggest to update the GitHub repository 'About' url from : relishapp.com/rspec/rspec-core to https://rspec.info/documentation/latest/rspec-core/ as it might be currently confusing for the users that are not aware that Relish docs are down.
from rspec-core.
@JonRowe If I replace 3.12
in https://rspec.info/documentation/3.12/rspec-core/RSpec/Core/Configuration.html#disable_monkey_patching!-instance_method to latest
, it redirects to the right page, but the #disable_monkey_patching!-instance_method
anchor is lost.
from rspec-core.
@pirj hi, correct, it's the same case for me.
btw I have tried to open Pull Request with updates for links from RelishApp to RSpec.info around the whole repository, but while doing so I'm getting 403 error:
➜ rspec-core git:(main) git checkout -b issue-3031
Switched to a new branch 'issue-3031'
➜ rspec-core git:(issue-3031) git push -u origin issue-3031
remote: Permission to rspec/rspec-core.git denied to tomczak-mateusz.
fatal: unable to access 'https://github.com/rspec/rspec-core.git/': The requested URL returned error: 403
any ideas what's wrong with this flow? 😕 it's not clear to me after following https://github.com/rspec/rspec-core#contributing
from rspec-core.
Nice catch. Other repos, too, and rspec-rails
to https://rspec.info/documentation/latest/rspec-rails
from rspec-core.
@pirj @JonRowe I have taken the opportunity to open the issues for 'About' url updates in each of the repos that mentions Relish for consistency & track ability:
rspec-core
: #3032
rspec-mocks
: rspec/rspec-mocks#1543
rspec-expectations
: rspec/rspec-expectations#1417
from rspec-core.
@JonRowe If I replace
3.12
in https://rspec.info/documentation/3.12/rspec-core/RSpec/Core/Configuration.html#disable_monkey_patching!-instance_method tolatest
, it redirects to the right page, but the#disable_monkey_patching!-instance_method
anchor is lost.
@JonRowe if it's possible to fix rspec.info docs to work with latest in the url path and to not drop the anchor part like in the example above - I would be very happy to update all Relish related links in rspec-core
, rspec-rails
, rspec-mocks
, and rspec-expectations
to work with rspec.info.
Please confirm if that's doable. 😉
from rspec-core.
@tomczak-mateusz I guess this is handled here and here if you feel adventurous enough to try fixing the missing anchor.
from rspec-core.
Fixed in #3035
from rspec-core.
Remove of the link in generated content was released in 3.12.2
from rspec-core.
Related Issues (20)
- How can I add a custom command option for rspec --order like `rspec --order prioritized` HOT 2
- Option for "Caused by" backtraces to print more than just the first line HOT 3
- Feature Request: means of troubleshooting intermittent failures that do not depend on sequence HOT 4
- update repository 'About' setting to use rspec.info docs url instead of Relish
- suggest an option for splitting specified files HOT 1
- Request for an _appropriate_ way to tell if all of the examples in a given ExampleGroup are being executed
- Raise errors if `it` executed in a `before` block HOT 1
- Introduce stub_env helper HOT 1
- Nested `skip` behaves weird, is this intended? HOT 1
- Shared contexts/examples files_organization / code_loading HOT 6
- Calling `before` or `after` in an invalid context that will never run should raise an error HOT 3
- RSpec skipping at_exit hooks on force quit HOT 1
- No way to filter tags with and logic HOT 3
- The SPEC environment variable does not support using bracketed example IDs HOT 9
- Guard against name collisions with internals HOT 2
- add :context scope to let method HOT 2
- Add `--only-pending` CLI option which filters to only the pending examples HOT 3
- Requiring rspec before IRB console causes warning HOT 1
- doc_string which is the first argument of example, must be string object HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rspec-core.