Comments (3)
After thinking about it some more, the core of the problem was that I was losing a reference to $ (jQuery) β I believe the mangler was using $ for a symbol of it's own. So, it may be more of an issue that somehow the mangler needs to know what identifiers it should not use when mangling at the top level.
Regardless, of how you look at it, this approach still handles it by leaving the global scope alone.
from slimit.
I think it's a good idea not to mess with global scope by default.
I made some changes so that Slimit doesn't mangle global scope any more and added a -t / --mangle-toplevel command line option that allows you to enable the global scope mangling for better minification results if that's what one needs and understands the possible consequences.
from slimit.
Sounds like a good solution. Thanks!
from slimit.
Related Issues (20)
- Parse function breaks when thereβs a line ending in a string HOT 5
- Syntatically wrong callback function validation check succeeds even though it would fail in a browser. HOT 2
- SyntaxError: Unexpected token (CLASS, 'class') HOT 1
- Unexpected token (ID, 'params') HOT 1
- Unexpected token (DELETE, 'delete') HOT 1
- Having promise catch statement breaks the minification HOT 1
- Release? HOT 4
- Minify fails on jquery file HOT 1
- Bug: Error when parsing "`" HOT 2
- how can i get the line number of the node in ast tree? HOT 2
- parser option
- Lose "()" after parse and cause Syntax error in js HOT 3
- Proposing a PR to fix a few small typos
- Release please: No longer installable on Python 3 due to setuptools dropping build_py_2to3 HOT 1
- keywords incorrectly disallowed as object property names HOT 1
- update pypi to reflect python 3 support
- Is there any plans for supporting ES6. HOT 1
- Switch default statement position not preserved (it is not always the last statement)
- Unexpected Token error -- script or slimit issue? HOT 2
- Silence ply errors HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from slimit.