Giter Site home page Giter Site logo

Mangling and top level symbols about slimit HOT 3 CLOSED

rspivak avatar rspivak commented on August 29, 2024
Mangling and top level symbols

from slimit.

Comments (3)

davidkhess avatar davidkhess commented on August 29, 2024

After thinking about it some more, the core of the problem was that I was losing a reference to $ (jQuery) – I believe the mangler was using $ for a symbol of it's own. So, it may be more of an issue that somehow the mangler needs to know what identifiers it should not use when mangling at the top level.

Regardless, of how you look at it, this approach still handles it by leaving the global scope alone.

from slimit.

rspivak avatar rspivak commented on August 29, 2024

I think it's a good idea not to mess with global scope by default.
I made some changes so that Slimit doesn't mangle global scope any more and added a -t / --mangle-toplevel command line option that allows you to enable the global scope mangling for better minification results if that's what one needs and understands the possible consequences.

from slimit.

davidkhess avatar davidkhess commented on August 29, 2024

Sounds like a good solution. Thanks!

from slimit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.