Short and long screenshots have different widths despite `setDeviceMetricsOverride`

[bersbersbers]

Short and long screenshots have different widths despite `setDeviceMetricsOverride`

[bersbersbers]

This is what I was looking for:

library(chromote)
b <- ChromoteSession$new()
b$Emulation$setDeviceMetricsOverride(width = 1920, height = 1080, deviceScaleFactor = 1, mobile = FALSE)
b$Page$navigate("https://github.com/rstudio/chromote")
Sys.sleep(3)
b$screenshot("snap.png")

This snapshot comes out at width 1905 and may be the closest case to rstudio/shinytest2#171, and it is the case which is actually fixed by b$Emulation$setScrollbarsHidden(TRUE), somewhat regardless of where one puts it.

library(chromote)
b <- ChromoteSession$new()
# b$Emulation$setScrollbarsHidden(TRUE) # works
b$Emulation$setDeviceMetricsOverride(width = 1920, height = 1080, deviceScaleFactor = 1, mobile = FALSE)
# b$Emulation$setScrollbarsHidden(TRUE) # works
b$Page$navigate("https://github.com/rstudio/chromote")
b$Emulation$setScrollbarsHidden(TRUE) # works
Sys.sleep(3)
b$screenshot("snap.png")

This snapshot is 1920 pixels wide, as expected. Interestingly, screenshot() does call setScrollbarsHidden already, but that call seems to be ineffective for some reason:

chromote/R/screenshot.R

Line 52 in 865e24e

p <- self$Emulation$setScrollbarsHidden(hidden = TRUE, wait_ = FALSE)$

[hadley]

Closing, since it seems like you figured out a solution.