Continue button has stopped working on tutorials deployed to shinyapps.io

[rstudio]

Continue button has stopped working on tutorials deployed to shinyapps.io

[garrettgman]

@jjallaire I'm no longer sure that this is a shiny-prerender issue. Re-rendering and redeploying has failed to activate the Continue button on several more apps (even on apps that I delete from shinyapps.io before redeploying).

Instead, this reliably fixes the problem: after deploying the app and verifying that the Continue buttons do not work, I click "Start Over". Then the buttons begin to work.

[jjallaire]

I think the problem has to do with shiny_prerendered, particularly that we don't re-render the Rmd file if it hasn't changed. This means that when we update tutor with new features you need to force a re-rendering of your tutorials before deploying them. You can read about this here: http://rmarkdown.rstudio.com/authoring_shiny_prerendered.html#forcing-a-render The easiest thing to do is probably to just remove all the .html files and re-render the tutorials. Another approach is to just manually call rmarkdown::render on each of the tutorials.

…

On Friday, March 17, 2017, Garrett Grolemund ***@***.***> wrote: Continue buttons do not work for apps that I deploy to shinyapps.io, e.g. https://tutorials.shinyapps.io/00-setup/ Source code: https://github.com/rstudio/ggtutorials/blob/master/ tutorials/00-setup/00-setup.Rmd This began after I updated tutor from github this morning. The continue buttons work when I run the apps locally. I noticed this while updating tutorials to use as examples in the documentation. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#50>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGXx7f3ajIDOLCMtBXmOvms1T-pgv0lks5rmqNAgaJpZM4MgtzX> .

[garrettgman]

@jjallaire That seems to be the source, but re-rendering and redeploying did not fix the Continue button until I deleted the app from my shinyapps.io account and then redeployed it (a heavy handed attempt to clear the files on shinyapps.io). Is there a better way to make sure that the app is being re-rendered on the shinyapps.io server?

[jjallaire]

If there is a tutorial where you can still reproduce this would you mind capturing the JavaScript log both on page load and when you click the Continue button?

…

On Fri, Mar 17, 2017 at 10:22 AM Garrett Grolemund ***@***.***> wrote: @jjallaire <https://github.com/jjallaire> I'm no longer sure that this is a shiny-prerender issue. Re-rendering and redeploying has failed to activate the Continue button on several more apps (even on apps that I delete from shinyapps.io before redeploying). Instead, this reliably fixes the problem: after deploying the app and verifying that the Continue buttons do not work, I click "Start Over". Then the buttons begin to work. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#50 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGXx4mLyov8guUKsvgjjQ9QUe64sQMnks5rmrNfgaJpZM4MgtzX> .

[jjallaire]

Or just point me to a URL of a tutorial that exhibits this behavior

…

On Friday, March 17, 2017, JJ Allaire ***@***.***> wrote: If there is a tutorial where you can still reproduce this would you mind capturing the JavaScript log both on page load and when you click the Continue button? On Fri, Mar 17, 2017 at 10:22 AM Garrett Grolemund < ***@***.*** ***@***.***');>> wrote: > @jjallaire <https://github.com/jjallaire> I'm no longer sure that this > is a shiny-prerender issue. Re-rendering and redeploying has failed to > activate the Continue button on several more apps (even on apps that I > delete from shinyapps.io before redeploying). > > Instead, this reliably fixes the problem: after deploying the app and > verifying that the Continue buttons do not work, I click "Start Over". Then > the buttons begin to work. > > — > You are receiving this because you were mentioned. > > > Reply to this email directly, view it on GitHub > <#50 (comment)>, or mute > the thread > <https://github.com/notifications/unsubscribe-auth/AAGXx4mLyov8guUKsvgjjQ9QUe64sQMnks5rmrNfgaJpZM4MgtzX> > . >

[garrettgman]

All of the example tutorials seem to display the behavior when you visit them the first time. Here are some screenshots of https://tutorials.shinyapps.io/00-setup/ with the JavaScript console (is this the log you have in mind?)

Immediately after page load

After clicking "Continue" (no change)

After clicking "Start Over"

After clicking "Continue" a second time

Note that some of the tutorials begin with a Welcome section (##), but no sub-section (###) in the first topic. In these tutorials, the first Continue button is a proxy "Next Topic" button and works as expected. However, the true "Continue" buttons, which advance between sub-section do not work.

[robbyshaver]

So if you press "Start Over" everything works fine? If that's the case, I suspect this issue was caused by the recent code change of skipping sections instead of exercises.

[garrettgman]

That seems to be correct: pressing "Start Over" fixes the behavior for that session. If you visit this tutorial, there may be a second clue: https://tutorials.shinyapps.io/01-data-basics/ * The first "Continue" button is a proxy for a "Next Topic" button and works * After you click through, the second "Continue" button is a true Continue button that progressively reveals a sub-section. It doesn't work. * When you click "Start Over" to resolve the problem, the First "Continue" button changes into a blue "Next Topic" button (and everything works)

[jjallaire]

It sounds like though that this error occurs for even newly deployed tutorials (i.e. it happens until there is some history to replay at startup, if there is no history at startup then we get the JS error seen above). @robbyshaver Do you have enough to go on here?

[jjallaire]

@robbyshaver I can confirm that if you visit a tutorial for the very first time you will get that JavaScript exception (it goes away after "Start Over"). My guess is that your code is implicitly assuming that some history will have been played back from the server and when that isn't the case there is a data structure that isn't populated the way you expect.

[robbyshaver]

Looking at https://tutorials.shinyapps.io/01-data-basics/, here's the error I'm seeing in the console. It's old code - the exerciseSkipped function doesn't exist anymore.

[jjallaire]

Given that it's old code, Garrett there might be a problem with the machine you are deploying from having an older version of the package. Could you make sure to install from github and then try again?

…

On Fri, Mar 17, 2017 at 3:21 PM Robby Shaver ***@***.***> wrote: Here's the error I'm seeing in the console. It's old code - the exerciseSkipped function doesn't exist anymore. [image: image] <https://cloud.githubusercontent.com/assets/1553877/24063456/19c8dbea-0b36-11e7-8371-c618c6ffd6e1.png> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#50 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGXx1x72D614JEyshZHg4-5iYMyAC2Qks5rmvlEgaJpZM4MgtzX> .

[garrettgman]

Thanks @robbyshaver. It looks like there have been several pull requests since I updated tutor this morning, one involving exercise_skipper. I reinstalled tutor (right now), re-rendered each tutorial, and re-deployed to the links below, but I seem to get the same bad behavior (but maybe inconsistently? -- 00-setup seems to work).

Can you guys confirm?

https://tutorials.shinyapps.io/00-setup/
https://tutorials.shinyapps.io/01-data-basics/
https://tutorials.shinyapps.io/03a-data-manip-filter/
https://tutorials.shinyapps.io/03b-data-manip-mutate/
https://tutorials.shinyapps.io/03c-data-manip-summarise/

[robbyshaver]

Just took a look - the code running is more up to date and I am seeing tutor firing a section-skipped event on an undefined section when I first open some of the tutorials (3a and 3b).

However, the code does not include the possible fix I checked in a an hour or so ago, so if you could get the latest and repost, that would be helpful.

I'm also seeing occasional internal server errors when I open 01.

[jjallaire]

I saw those internal server errors as well, I'm not sure what that is. I'll post a bug for it and investigate later.

…

On Friday, March 17, 2017, Robby Shaver ***@***.***> wrote: Just took a look - the code running is more up to date and I am seeing tutor firing a section-skipped event on an undefined section when I first open some of the tutorials (3a and 3b). However, the code does not include the possible fix I checked in a an hour or so ago, so if you could get the latest and repost, that would be helpful. I'm also seeing occasional internal server errors when I open 01. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#50 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGXx3MxeVI9fmFItHQl0tdsH2KUOfG-ks5rmwy6gaJpZM4MgtzX> .

[garrettgman]

I re-installed tutor at 7:22 tonight after your messages and re-rendered, and re-deployed each tutorial. It seems to me that the Continue buttons may now work correctly.

[jjallaire]

I'll close this as it looks like the issues have been resolved. @garrettgman Please re-open if you see additional problems.

[garrettgman]

I've encountered this behavior again: the continue buttons do not work when I deploy to shinyapps.io_ (continue buttons always work locally).

I may have identified a cause:

If I deploy a tutorial after clicking "Start Over", or before completing any sections, the tutorial works correctly on shinyapps.io. For example, I deployed this tutorial in this way and it works correctly: https://tutorials.shinyapps.io/04-programming-basics. Here's how it looked before I deployed it

If I deploy the tutorial after completing sections and without clicking "Start Over", (e.g. with a history), the tutorial does not work on shinyapps.io. For example, I redeployed the same tutorial after completing a few sections here: https://tutorials.shinyapps.io/04-programming-basics-alt. In this version, the continue buttons do not work, with the exception of the continue button at the end of the first section (Welcome), which is actually a disguised "Next Section" button. Here's how the tutorial looked before I deployed it

Note: I can sometimes get the continue buttons to work in the broken tutorial by jumping around between sections within the tutorial.

TL;DR - It seems that you need to erase a local tutorials history by clicking "Start over" before you deploy it to shinyapps.io. If you do not, the continue buttons will not work when deployed.

[garrettgman]

An addendum to the last comment: the continue buttons for the good link above have stopped working for me on subsequent visits (https://tutorials.shinyapps.io/04-programming-basics).

I also notice that the tutorial does not seem to remember my progress when I revisit it later.

[jjallaire]

It's possible that this is a shinyapps.io error. @jspiewak I see the following 500 error when revisiting the tutorial on shinyappsio (this doesn't occur locally):

@garrettgman This 500 error would explain all of the other issues you are seeing regarding revisiting of tutorials.

[jjallaire]

I've confirmed that this also occurs on beta.rstudioconnect.com:

Simple repro Rmd is:

---
title: "Tutorial"
output: learnr::tutorial
runtime: shiny_prerendered
---

```{r setup, include=FALSE}
library(learnr)
knitr::opts_chunk$set(echo = FALSE)
```

## Topic 1

### Exercise 

*Here's a simple exercise with an empty code chunk provided for entering the answer.*

Write the R code required to add two plus two:

```{r two-plus-two, exercise=TRUE}

```

This is AFAIK a new error condition. Perhaps a change in a recent version of RSC or (less likely so) Shiny? @trestletech Could you take a look at this as well?

[robbyshaver]

I don't know if this is related or not, but when I try to view the tutorial at: https://tutorials.shinyapps.io/04-programming-basics, I get the following error:

[jspiewak]

@robbyshaver unrelated, that is bug with lucid where it doesn't deal with incorrectly cased applications. The actual URL is https://tutorials.shinyapps.io/04-Programming-Basics/

[garrettgman]

@robbyshaver I've seen that before, but thought it was my web browser autofill misfiring. When I retyped the URL it worked.

[garrettgman]

@jspiewak Should all application names be lower case? Good to know

[jspiewak]

Well, we should fix the bug for starters.
The work around is to use the same case in the URL as when the application was created.
If one always lower cases application names, then one doesn't need to think about it.
But really we should just fix the bug already. :)

[jjallaire]

I now have a local repro for the 500 error (it has to do with how jsonlite is round-tripping R data structures, perhaps something changed in the v1.5 version of jsonlite). More soon!

[jjallaire]

This should now be fixed. @garrettgman Could you confirm that all is well on your end?

[garrettgman]

Thanks guys. I can no longer reproduce the error.

@jjallaire I do notice two things. Let me know if you'd like me to open them as new issues:

1. There is a noticeable delay between when a tutorial loads and when it advances to the saved state.

2. I deployed the same tutorial in two places (to make the comparison above). They seem to share state now (each advances to where I left off in the other).
   https://tutorials.shinyapps.io/04-programming-basics/
   https://tutorials.shinyapps.io/04-programming-basics-alt/

[jjallaire]

What browser are you using when you see the shared state behavior? Could you send me the source code for that tutorial to aid in reproducding?

…

On Thu, Jun 15, 2017 at 3:11 PM, Garrett Grolemund ***@***.*** > wrote: Thanks guys. I can no longer reproduce the error. @jjallaire <https://github.com/jjallaire> I do notice two things. Let me know if you'd like me to open them as new issues: 1. There is a noticeable delay between when a tutorial loads and when it advances to the saved state. 2. I deployed the same tutorial in two places (to make the comparison above). They seem to share state now (each advances to where I left off in the other). https://tutorials.shinyapps.io/04-programming-basics/ https://tutorials.shinyapps.io/04-programming-basics-alt/ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#50 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAGXx8iV2tp6IhneS6MJnu2FABtdBdcwks5sEYHxgaJpZM4MgtzX> .

[garrettgman]

@jjallaire, I am using Google Chrome. Here is the source code:
https://github.com/rstudio/ggtutorials/blob/master/the-basics/04-Programming-Basics/04-Programming-Basics.Rmd

[jjallaire]

Okay, found the problem. All should be well! (please test your tutorials and let me know if you see any problems)

[garrettgman]

Ferit observed the behavior reported in the original issue today (10/17/2018) while working through https://rstudio.cloud/learn/primers/2.3, i.e.

The second Continue button in the tutorial did not advance the tutorial in Google Chrome (the first Continue button is a Next Topic button). The Continue button began to work when he revisited the tutorial later.

[schloerke]

This seems to be working. Closing

[amf60]

R studio Cloud - Primer - Iterate - "Continue" button issue -

despite having correctly answered the exercise the progress to next part is blocked by a pop window saying "You must complete the exercise in this section before continuing". Forced the way to the next part and got the same issue with the other sessions of iterate. So I am uncertain of the real progress done with this very important lesson. Thank you in advance for your help.