Giter Site home page Giter Site logo

Comments (4)

BDonnot avatar BDonnot commented on August 13, 2024

Hello,

I think this behaviour, though a bit surprising is perfectly fine. In fact, this action is "Ambiguous" (there is no unique way to understand what the user meant by this action).

In this case, it is ambiguous because you asked to connect a powerline, without specifying on which bus. There are 4 different ways to reconnect a powerline in grid2op:

  • connect it to bus 1 on origin and bus 1 on extremity
  • connect it to bus 2 on origin and bus 1 on extremity
  • connect it to bus 1 on origin and bus 2 on extremity
  • connect it to bus 2 on origin and bus 2 on extremity

As it's not clear what you meant by "reconnecting" powerline 3 and 4, then it is not performed on the powergrid. On the real "env.step" this is tagged in the "infos" dictionnary. Il will work on adapting it to the "obs.simulate" too.

Note that this behaviour is explained in the text bellow de description of the action:

NB this action is ambiguous so it cannot be implemented on the powergrid. Indeed, powerlines 3 and 4 are reconnected, but we don't specify on which bus!

The fact that the action is silently not implemented is pretty common in video games. For example, in pacman, when you face a wall and want to go forward, you can't (because you face the wall) but nothing is done: the game doesn't crash, and the walls are not "lava". That's the same behaviour in grid2op. Facing an ambiguous or illegal action is equivalent do doing nothing.

I agree this makes a poor example. I will try to rework this part. I switch your issue to an enhancement on the 2nd getting started.

from grid2op.

jhmenke avatar jhmenke commented on August 13, 2024

Thanks for the answer!

Then i find the notebook a bit confusing, at least for the change_line_status case (see other issue). The demo action does not specify that i need to define a bus for changing the status:

the_same_act = action_space({"set_line_status": [(3,1), (4,1), (5,-1), (6,-1)],
"change_line_status": [0,1,2]
})
print(the_same_act)

from grid2op.

BDonnot avatar BDonnot commented on August 13, 2024

Indeed i will make it more explicit. Thanks for the valuable comment.

from grid2op.

BDonnot avatar BDonnot commented on August 13, 2024

This issue has been fixed in latest version (that i'm testing for integration at the moment).
Thanks again for the feedback.

from grid2op.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.