Giter Site home page Giter Site logo

Comments (7)

ruanyf avatar ruanyf commented on April 20, 2024

谢谢指出,这个判断确实是多余的。我把它删掉。

from react-demos.

vipcxj avatar vipcxj commented on April 20, 2024

并不一定吧~ isMounted是在回调函数中,并且涉及网络请求,没人能保证它执行的时候仍旧是Mounted的

from react-demos.

yuxino avatar yuxino commented on April 20, 2024

@vipcxj componentDidMount是在isMounted状态为true的时候执行的回调函数,所以是可以保证的。我刚才仔细看了一下README的实例是正确的,有误的只是demo11文件夹里面的那个实例代码。而且这个东西不好

from react-demos.

vipcxj avatar vipcxj commented on April 20, 2024

@Nbsaw 没记错的话,应该是执行get网络请求后才调用的回调函数,如果网比较差,这就会有一个时间差了啊,如果期间被unmount了,也是可能的

from react-demos.

ruanyf avatar ruanyf commented on April 20, 2024

理论上,获取到数据的时候,组件是可能被卸载的。但是,这个例子里,确实是多余的判断。

另外,isMounted这个 API 也已经被废掉了,所以还是去掉比较好。facebook/react#5465

from react-demos.

vipcxj avatar vipcxj commented on April 20, 2024

@ruanyf 我把整个issure都看了下,基本就是react的开发者嫌isMounted不够优雅,想废除它,但又没在react内部给一个完美的代替方案,所以另一个react的贡献者就不同意了。然后就是提出各种workaround,然而所有workaround都不是react自带的,全部仅仅是workaround~ 没看到这个issure的岂不是要被坑?

from react-demos.

ruanyf avatar ruanyf commented on April 20, 2024

isMounted 确实被废掉了。https://github.com/facebook/react/blob/3c977dea6b96f6a9bb39f09886848da870748441/packages/react/src/ReactBaseClasses.js#L89

from react-demos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.