Giter Site home page Giter Site logo

Comments (2)

andrewdalpino avatar andrewdalpino commented on May 12, 2024 1

This was a curious issue

It looked as if after the Parameter objects were deserialized from persistence they hashed to a slightly different value even with the Native serializer (off by 1ish) and a more different value with the Binary serializer (off by 7ish)

Rather than having to go through the igbinary guys to see if it was a bug with their extension, I just designed the cache differently and now we don't have to worry about object hashes at all

You can try it out using the current dev-master branch, or you can wait for the next beta release in a few days

Thanks again for the great bug report

from ml.

andrewdalpino avatar andrewdalpino commented on May 12, 2024

Thank you for the great bug report

This is an interesting one

The bug appears after reconstituting a binary serialized neural network based estimator such as MLP or Logistic Regression with an Adaptive Optimizer (Adam, Momentum, etc.)

Indeed, everything works fine using the Native serializer, and a non-adaptive optimizer (Stochastic, Cyclical, etc.) work ok as well

My gut says that it's something with the igbinary extension (the extension doing the work under the hood)

Specifically, it might have a problem serializing/unserializing the \SplObjectStorage (a hash map structure that uses object hashes as keys)

For example, maybe the object hashes are not being preserved through the deep freeze

That cache you see on line 119 is an \SplObjectStorage that holds the per parameter running velocities and squared gradients needed for the adaptive calculation

\SplObjectStorage is one thing that all the Adaptive Optimizers have in common

I'm going to continue doing some research

from ml.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.