Giter Site home page Giter Site logo

Comments (3)

pirj avatar pirj commented on May 27, 2024

Thanks for reporting!

(...2).exclude_end? # => true
(..2).exclude_end? # => false
(2...).exclude_end? # => true
(2..).exclude_end? # => false

Rails makes no difference between 7.days.ago.. and 7.days.ago..., and it seems to be a bug. Do you have the same impression?

Since we're recommending this as a replacement in our examples:

# bad
User.where("created_at > ?", 7.days.ago)

# good
User.where(created_at: 7.days.ago..)

and it's actually incorrect, would you like to send a PR with correct examples and maybe more details?

from rails-style-guide.

justindell avatar justindell commented on May 27, 2024

It looks like this is intended behavior, because ranges are inclusive or exclusive based on their ending and beginnings are always inclusive.

There's some discussion here: rails/rails#40628

You can get the intended behavior by using where.not, but I find that to be confusing and counter-intuitive

 Client.where.not(id: ..7).to_sql
# "SELECT \"clients\".* FROM \"clients\" WHERE \"clients\".\"id\" > 7"

I'll work on a PR to make this behavior clearer, but personally I think I'll stick with ranges only with defined start's and end's. With endless ranges, I think the comparative conditions format is more clear and less prone to unexpected bugs.

from rails-style-guide.

pirj avatar pirj commented on May 27, 2024

You're right! I've completely missed that there is no difference between an inclusive and exclusive endless ranges, TIL.
Thanks for the interesting reference.

from rails-style-guide.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.