Comments (4)
That's new to me. Rails always has something up its sleeve.
A configurable boolean attribute StrictValidations
that would ignore non-bang persistence methods could be useful.
from rubocop-rails.
Hmm, is there any opposition to adding such a cop for those who are not using strict validations? While that seems like a nice option, it would require more code changes, and in the meantime this cop would probably help a lot of people if it was available.
With strict validations a simple version of this cop would have false positives, but someone using strict validations could just disable it? Not sure what level of static analysis could be done to figure out whether the class in question is using strict validations or not.
from rubocop-rails.
If a model was using strict validations, save
can raise ActiveModel::StrictValidationFailed
which would trigger a rollback.
https://guides.rubyonrails.org/active_record_validations.html#strict-validations
from rubocop-rails.
Sorry for digging up on this old issue. But I think it still makes sense to have such a cop. I may not want to make all my validations strict, just the ones in an explicit transaction.
from rubocop-rails.
Related Issues (20)
- Rails/SaveBang doesn't work well with postfix `if` HOT 1
- Make `Rails/PluckInWhere` aware of `.ids` HOT 1
- No `#minimum_target_rails_version` for some cops HOT 1
- Outdated note for the `Rails/ContentTag` cop
- Cop idea: Redundant #alias_attribute for associations HOT 2
- Rails/WhereNot raises an error
- Error while Rails/UniqueValidationWithoutIndex cop was inspecting HOT 3
- Use ActiveSupport DateAndTime predicates HOT 1
- `Rails/SaveBang` does not work with instance variables HOT 1
- `Rails/Savebang` fails when `persisted?` is checked on a broader expression
- `Rails/ReversibleMigrationMethodDefinition` false positive when `up` and `down` defined as class methods HOT 1
- Incorrect autocorrect for `Rails/FindBy` cop
- Cop suggestion: disallow `return` in tests HOT 2
- Cop to detect deprecated enums with keyword arguments HOT 3
- `Rails/UniqueValidationWithoutIndex` should not fail when have index HOT 1
- False Positive for `Rails/ActionControllerFlashBeforeRender` when flash is called in a case statement
- False positive for `Rails/ActionControllerFlashBeforeRender` when using `return redirect_to`
- Error occurred with `ActiveRecord::ModelSchema::ClassMethods#ignored_columns=`
- Please remove `Rails/UnusedIgnoredColumns` HOT 1
- Error occurred for `Rails/Present` was auto correcting HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from rubocop-rails.