More cops(rules)

[rubocop]

More cops(rules)

[jonas054]

I want to do "Use only ascii symbols in identifiers and comments". The list is a great idea, by the way.

[bbatsov]

It's yours then.

[jdanielnd]

I've written a cop for "Prefer %w to the literal array syntax when you need an array of strings." and now it detects that style rule on various code files from the project. Should I correct them to match this new rule too?

[bolandrm]

This can be crossed off the list:

• Avoid methods longer than 10 LOC (lines of code). Ideally, most methods will be shorter than 5 LOC. Empty lines do not contribute to the relevant LOC. (this cop should have configurable max length)

I'm going to work on "When using reduce with short blocks, name the arguments |a, e|"

[bbatsov]

I guess I crossed it off just as you were typing this comment. :-)

Great, looking forward to it.

[jonas054]

I'll do "Use %r only for regular expressions matching more than one '/' character".

[emou]

I'll look into "Avoid more than three levels of block nesting."

[bbatsov]

Great, @emou. I'd suggest to actually use a customizable param for that particular check(instead of hardcoding 3), since a lot of people might disagree with the number prescribed by default.

[bbatsov]

I'll do 'Favor %r if you have more than 1 '/' characters in your regexp'.

[jurriaan]

What do you think about an indentation Cop?

ps. Could you use a task list? I think that's more clear.

[bbatsov]

Yep, that would be a great addition. The ruby interpreter detect misaligned ends, but nothing more than that. An indentation cop would be an awesome addition. Do you volunteer to write it? :-)

ps. Will do!

[bbatsov]

Done.

[bbatsov]

@jonas054 @yujinakayama I think we should try to wrap this issue before 1.0. I'd suggest we continue the old practice of doing a cop at time until we're out of cops. I'll start with the unneeded return check.

[jonas054]

I'll do Avoid self where not required.

[bbatsov]

I'll do the implicit begin next.

[jonas054]

I'll do "Comment annotation should be all upper case and at the beginning of the comment".

[jonas054]

I'll do "Prefer modules to classes with only class methods" next.