Giter Site home page Giter Site logo

Gem ship. about openssl HOT 30 CLOSED

ruby avatar ruby commented on May 20, 2024 2
Gem ship.

from openssl.

Comments (30)

hsbt avatar hsbt commented on May 20, 2024

I send transfer offer to openssl owner.

from openssl.

rhenium avatar rhenium commented on May 20, 2024

I contacted the current owner at mbailey/openssl#1 and @mbailey agreed with releasing the gem namespace.

from openssl.

hsbt avatar hsbt commented on May 20, 2024

oops. Should I continue to transfer negotiation instead of you?

And I sometimes request to remove stdlib protection to rubygems admins. see. rubygems/rubygems.org#1273

from openssl.

hsbt avatar hsbt commented on May 20, 2024

commented mbailey/openssl#1 (comment)

from openssl.

hsbt avatar hsbt commented on May 20, 2024

note: rubygems/rubygems#1663 , rubygems/rubygems.org#1373

from openssl.

zzak avatar zzak commented on May 20, 2024

I guess we still need to decide a version number?

from openssl.

hsbt avatar hsbt commented on May 20, 2024

@rhenium I've been promoted openssl owner by rubygems admins. Can you give your mail address on rubygems?

from openssl.

rhenium avatar rhenium commented on May 20, 2024

@hsbt Thank you always! My email is k(at)rhe.jp.

from openssl.

hsbt avatar hsbt commented on May 20, 2024

@rhenium I added owner grant to you. If you are ready to ship openssl gem, I'm going to request to remove openssl from rubygems blacklist.

from openssl.

rhenium avatar rhenium commented on May 20, 2024

@hsbt Thanks!

It looks like openssl is already excluded from the list, at least in the source repository. rubygems/rubygems.org@6e74bd9

I think we can release now if only we decide the version number.

from openssl.

zzak avatar zzak commented on May 20, 2024

@hsbt @rhenium お疲れさまです! I will review #59 and commit my changes to the documentation.

Regarding the NEWS, as of 1b8bcdb the organization is:

  • Compatibility
  • Updates since 2.3 (in order of class)

However, there is some duplication between the updates and compatibility list.

I will review this too, but first I think we could split it up similar to Rails release notes as such:

  • Compatibility notes (with regards to OpenSSL versions)
  • Supported platforms (with current release)
  • Changes in current release

Changes would include the following:

  • Notable changes (such as breaking api, or additions, features, etc)
  • Removals (Already deprecated features that were removed)
  • Deprecations (Stuff to be removed next release)

One other idea is after the release is made, we should consider moving the NEWS document like we do with Ruby, i.e.: docs/NEWS-2.4.0

Thanks for taking the time to work on this and prepare the release!

I will submit my thoughts in the form of a patch :)

from openssl.

rhenium avatar rhenium commented on May 20, 2024

@zzak Thanks! That's a great help.

One other idea is after the release is made, we should consider moving the NEWS document like we do with Ruby, i.e.: docs/NEWS-2.4.0

I think we can just append on top, each release note would be smaller than Ruby. Maybe I should have named it History.

from openssl.

zzak avatar zzak commented on May 20, 2024

Append is also fine! Let's go with History.

from openssl.

zzak avatar zzak commented on May 20, 2024

@rhenium @hsbt I sent a PR with my changes, please check it when you're ready

I think we can also close #54 once this is done, thanks!!

from openssl.

rhenium avatar rhenium commented on May 20, 2024

@zzak Thank you! It looks much nicer! Do you have suggestions on changes in README.md and CONTRIBURING.md?

from openssl.

zzak avatar zzak commented on May 20, 2024

@rhenium Thanks, I will review.

from openssl.

hsbt avatar hsbt commented on May 20, 2024

OpenSSL::VERSION already retunes "1.1.0". We should use 2.0.0 when releasing openssl gem.

from openssl.

rhenium avatar rhenium commented on May 20, 2024

OpenSSL 1.1.0 was just released today, and Ruby/OpenSSL looks working fine with it: https://travis-ci.org/ruby/openssl/builds/155282416

Is there still a blocker for the release?

from openssl.

hsbt avatar hsbt commented on May 20, 2024

Is there still a blocker for the release?

There is no blocker for me :octocat:

from openssl.

zzak avatar zzak commented on May 20, 2024

I have no blockers, version 2.0.0 sounds fine.

Let's yank the current gems from rubygems.org and cut a pre-release?

from openssl.

rhenium avatar rhenium commented on May 20, 2024

Let's yank the current gems from rubygems.org and cut a pre-release?

I think so! Can I do that?

from openssl.

zzak avatar zzak commented on May 20, 2024

@rhenium Yes, if you are authenticated on rubygems.org, via the gem command you can yank the old versions with:

gem yank openssl -v '0.2.0'
gem yank openssl -v '0.1.0'

And to publish (after updating version.rb):

gem build openssl.gemspec
gem push openss-2.0.0.beta1.gem

For example if you wanted to choose "beta1" as the first pre-release.

from openssl.

rhenium avatar rhenium commented on May 20, 2024

Just pushed openssl-2.0.0.beta1: https://rubygems.org/gems/openssl

from openssl.

rhenium avatar rhenium commented on May 20, 2024

Imported to trunk at: ruby/ruby@c9dc016

from openssl.

zzak avatar zzak commented on May 20, 2024

@rhenium Ah great!

Btw, I think two things are missing in History from #18, that is ALPN and ECDH callback support.

We can add it to the news in the next beta/rc?

edit: also, I want to "linkify" the History.md so we can click through the tickets/PRs from there

from openssl.

zzak avatar zzak commented on May 20, 2024

Linkify in #69

from openssl.

zzak avatar zzak commented on May 20, 2024

@tenderlove BTW bro, the tmp_ecdh_callback stuff was removed in favor of ecdh_curves: https://github.com/ruby/openssl/blob/v2.0.0.beta.1/History.md#deprecations

from openssl.

rhenium avatar rhenium commented on May 20, 2024

@zzak ALPN and ECDH callback are part of Ruby 2.3 (though they aren't in doc/NEWS-2.3.0).

from openssl.

zzak avatar zzak commented on May 20, 2024

@rhenium Ahh, ok! I will revert 59b22d4 then.

from openssl.

hsbt avatar hsbt commented on May 20, 2024

Gem ship is done. ref. https://rubygems.org/gems/openssl/versions/2.0.0.beta.1

from openssl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.