Warning/error messages mismatching

[andrykonchin]

Warning/error messages mismatching

[kddnewton]

For the first one, yeah I suppose I'm returning the Ruby 3.4 error message and not the Ruby 3.3 error message, so I can fix that. For the second one, yeah I would concatenate them before you check, it's not always going to be the first error.

[andrykonchin]

It seems pretty expected to have multiple syntax errors returned if the parser is used as a tool. But wondering how CRuby will (or already does) decide on which error message to use. And we are supposed to use the same approach in TruffleRuby to be compatible.

[andrykonchin]

Got it, thank you! So feel free to close this issue if it isn't needed to track any planned changing.

[eregon]

For the first one I think it's alright to use the clearer 3.4 error message even with version 3.3, we can just adapt specs to accept both, it doesn't seem worth adding a condition in Prism for this.

[andrykonchin]

Right, the ruby/spec's tests were changed to expect Prism-specific messages as well.

[kddnewton]

Perfect, thanks!