Giter Site home page Giter Site logo

Comments (7)

eregon avatar eregon commented on September 14, 2024 4

@eregon #540, other actions increased their major version for this change. e.g. https://github.com/actions/checkout/releases/tag/v4.0.0

Yeah I know. IMO that's unnecessary work, it's making everyone change things when nothing needs to change in their workflow actually, at least as long as they are running on GitHub-hosted runners. And if not, then node20 should be installed on self-hosted runners. So anyway, nothing meaningful to change for workflows, so a waste of a major version.

from setup-ruby.

TWiStErRob avatar TWiStErRob commented on September 14, 2024 1

That's a node package, embedded into dist. I don't think GHA can see that.

Are you sure there's no actions/cache@v3 in your workflow or one of the composite actions?

from setup-ruby.

eregon avatar eregon commented on September 14, 2024

Could you make a PR? You just need to change https://github.com/ruby/setup-ruby/blob/master/action.yml

from setup-ruby.

TWiStErRob avatar TWiStErRob commented on September 14, 2024

@eregon #540, other actions increased their major version for this change.
e.g. https://github.com/actions/checkout/releases/tag/v4.0.0

from setup-ruby.

TWiStErRob avatar TWiStErRob commented on September 14, 2024

Note: the warning won't show for now: actions/upload-artifact#444 (comment), but a released version should be ready for when they bring it back.

from setup-ruby.

srallen avatar srallen commented on September 14, 2024

👋 I'm still seeing warnings about upgrading to Node 20:

Screenshot 2024-02-16 at 5 10 57 PM

I believe this is due to this action's use of actions/cache@v3:

"@actions/cache": "^3",
Version 4 for actions/cache doesn't appear to actually have breaking changes. Would it be possible for this action to bump to v4 of actions/cache?

from setup-ruby.

srallen avatar srallen commented on September 14, 2024

@TWiStErRob I found v3 of action/cache in another 3rd party composite action that I missed the first time through trying to find the source of the warning I was seeing. Thanks for taking the time to respond.

from setup-ruby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.