Giter Site home page Giter Site logo

Comments (8)

korny avatar korny commented on July 18, 2024

I tested on 1.6.4. Will investigate.

from coderay.

korny avatar korny commented on July 18, 2024

Jup. Strange; what's going on there…

from coderay.

graaff avatar graaff commented on July 18, 2024

If the conclusion is that jruby 1.5 is broken then that is fine with me, but unfortunately we're still stuck with that version of jruby on Gentoo which means I'll have to wait to add coderay 1.0.0 to Gentoo until that is resolved.

from coderay.

korny avatar korny commented on July 18, 2024

I see. Even if it's an incompatibility issue on 1.5.4, I'd like to make it work for you.

  • The first Failure is not problematic, since it's just an expected warning missing.
  • The second one might also not be a problem if you don't use plugins except for the ones in the distribution.

So I'd say, try to upgrade — even with the failing tests (for now).

from coderay.

graaff avatar graaff commented on July 18, 2024

We offer our users the option to run tests as part of the installation procedure of a package (for ruby as well as other packages that offer tests), so I can't just update the package without addressing this in a more structured way, either by removing the specific failing tests or depending on jruby 1.6 once that is added to Gentoo. Bit strapped for time now but I'll keep in mind that I can drop those tests if needed.

from coderay.

korny avatar korny commented on July 18, 2024

Commit ec60c83 fixes the first issue; the test was broken here, not the library.

The second issue is caused by a JRuby bug that has been fixed in 1.6: http://jira.codehaus.org/browse/JRUBY-4885?page=com.atlassian.jira.plugin.system.issuetabpanels%3Aall-tabpanel

from coderay.

graaff avatar graaff commented on July 18, 2024

Thanks for looking in to this. For Gentoo I've commented out both tests for now, until we can depend on jruby 1.6. I guess this can be closed?

from coderay.

korny avatar korny commented on July 18, 2024

Okay.

from coderay.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.