Giter Site home page Giter Site logo

Comments (7)

korny avatar korny commented on July 18, 2024

Unfortunately, that's not so easy. The fix was a refactorization of the Terminal encoder.

I would rather spend the time solving the problems that hold off using 1.0 with Pry: #6

Do you agree?

from coderay.

envygeeks avatar envygeeks commented on July 18, 2024

I'm not trying to be ungrateful for your project because it's legit but I think if it was that important you would have applied Occam's razor and done what Yard does, or what you assumed would fix it -- in your last comment -- on #6 (which is the fix in most cases.) So, no I don't agree even though I don't know your schedule or order of importance on critical issues. I know @ConradIrwin applied a temporary patch for this issue... but I think it got reverted so I will dedicate my time to also fixing this issue in pry if it hasn't been reverted.

from coderay.

korny avatar korny commented on July 18, 2024

Can we close this issue when #6 is solved?

from coderay.

envygeeks avatar envygeeks commented on July 18, 2024

Once #6 gets merged into a gem update I'll be testing the 1.0.5 against Pry and then I'll close it if all goes well.

from coderay.

korny avatar korny commented on July 18, 2024

Looks good on Travis :) So, 1.0.5.rc1 is out and ready for testing.

from coderay.

envygeeks avatar envygeeks commented on July 18, 2024

All good from here, had no problems with 1.0.5 so once it goes stable I'll suggest it get updated in Pry too.

from coderay.

korny avatar korny commented on July 18, 2024

Yay :D

from coderay.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.