Giter Site home page Giter Site logo

Comments (6)

namelessjon avatar namelessjon commented on August 24, 2024

Also, whatever its called, its pretty easy to write. Most of the specs are the same as the Boxer class, since the 'KATs', such as they are, from libsodium/test uses the same key as derived from the example key pair.

from rbnacl.

tarcieri avatar tarcieri commented on August 24, 2024

I'd actually keep it SecretBox personally, and rename SecretKey to PrivateKey.

And you definitely deserve a commit bit man, thanks for all the awesome work you've been doing! 👍

from rbnacl.

tarcieri avatar tarcieri commented on August 24, 2024

You should now have commit access

from rbnacl.

namelessjon avatar namelessjon commented on August 24, 2024

Thanks!

I did originally have it as PrivateKey, but then all the docs for the library, and the constants, have it as 'secret key'. I'll switch it over. Also, I'm going to rename Boxer to Box I think. While it is, strictly, making crypto_boxes rather than being one, Boxer just sounds odd as a class.

from rbnacl.

tarcieri avatar tarcieri commented on August 24, 2024

Heh, I was just thinking about bringing that up as it were. +1 on Boxer => Box.

Also the nomenclature I prefer at least, some may disagree:

  • symmetric crypto: secret key
  • asymmetric crypto: public key / private key

from rbnacl.

namelessjon avatar namelessjon commented on August 24, 2024

Yeah, I prefer it that way too. Was just going for consistency with NaCl. At times, a hard task ...

from rbnacl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.