Comments (3)
@lmerriam I put checkin creation logic on the backend because I think it's safer. It basically initializes checkin with all currently tracked conditions and symptoms, with no values, and all currently tracked treatments, with a "not taken" state and their most recent dose if present in user's profile. I would like to keep this logic on the backend, so that it doesn't need to be replicated by mobile apps.
With that said, individual checkin steps and summary screens on the Ember app are currently created based on an existing checkin record. So basically, if user is for example on symptoms step of today's checkin, and moves back to yesterday, the Ember app doesn't know which symptoms to show if checkin for that day doesn't exist yet.
So I think, if the actual issue is that you want to get rid of empty summaries, I would suggest we put in place one of the following logics:
- make the app aware of when a checkin is empty (i.e. user has never entered data in it) and, when user clicks on a day on the graph: if checkin is empty, show the checkin start screen; else, show the summary screen
- make the app aware of when a user has completed all checkin steps (i.e. for a given day, user has reached the checkin summary screen) and, when user clicks on a day on the graph, take him to the last step he completed, or to the summary if he completed all steps
Let me know what you think about my proposals.
from flaredown.
Sounds good to me! First bullet point definitely, but I don't think we actually need to worry about the second one -- if someone decides to leave their check-in and come back later I'm fine with them completing it through the summary screen.
from flaredown.
@lmerriam Implemented first solution, as per your suggestion
from flaredown.
Related Issues (20)
- User request: see a chart for longer periods of time? One month? One year? HOT 1
- User issue: vanishing treatments between checkins HOT 1
- Feature request: update checkin date HOT 1
- Accept the terms sign up checkbox misplaced HOT 2
- Android app won't run on Android 12 (or above?)
- Emotion icons except first missing from symptom checkin (Web)
- Setup staging HOT 3
- upgrade ruby to latest HOT 1
- [native] Wire login page to backend
- [native] Create account from sign up page
- [native] Add captcha to sign up page HOT 2
- [native] Terms of service and Privacy policy page HOT 1
- [native] Update `react-native-paper` theme to match designs
- Blank login page on first load
- add brakeman security scanner
- Rspec workflow is broken
- Upgrade to Rails 7 HOT 1
- upgrading either rack or puma broke prod cors so I reverted, make the upgrade not do that HOT 1
- upgrade ruby from 3.1.3 to 3.2.3 HOT 2
- fix and add readme CI badges
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from flaredown.