Giter Site home page Giter Site logo

Comments (19)

algodave avatar algodave commented on June 27, 2024

Summary of slack conversation with @lmerriam to clarify reqs

  • as soon as the user "turns on" a treatment, it automatically gets its last dose, if it has one
  • it would look at the last day the user logged prior to the day they are checking in and use that dose
  • this can be done whatever the checkin day is, so no reason to differentiate behavior between today's checkin and past days

from flaredown.

lmerriam avatar lmerriam commented on June 27, 2024

👍

from flaredown.

lmerriam avatar lmerriam commented on June 27, 2024

@algodave this isn't quite working for me, I still get "no dose" on all my treatments when I add them

from flaredown.

algodave avatar algodave commented on June 27, 2024

@lmerriam can you provide an example treatment you added which was not populated? Consider that currently you have to wait one second before "turning-on" the treatment just added in order to see the auto-set dose (sorry I should have mentioned that)
I'll fix this together with #3 which will provide the app with better awareness on when to trigger checkin save.

from flaredown.

lmerriam avatar lmerriam commented on June 27, 2024

Prednisone, Stelara, Folic Acid, Methotrexate on my [email protected] account

Just tried again waiting 10 seconds, I still see the issue unfortunately

from flaredown.

algodave avatar algodave commented on June 27, 2024

@lmerriam I should have found what the issue was. I was discarding null doses but not blank ones. Please try again when you have a chance and let me know. Also note: on a new checkin default doses are immediately available; when you add a new treatment instead, you have to wait one second.

from flaredown.

lmerriam avatar lmerriam commented on June 27, 2024

Looks good now 👍

from flaredown.

lmerriam avatar lmerriam commented on June 27, 2024

@algodave still seeing issues: https://www.dropbox.com/s/zjz5t0f651auuas/autoTreatmentDose.mov?dl=0

from flaredown.

algodave avatar algodave commented on June 27, 2024

@lmerriam just watched the video. The checkin you clicked on already existed before I released the feature, that means the object was initialized without most-recent doses. I realized that because the summary screen opened up rather than the first checkin screen (the "You haven't checked-in yet").
So to recap: the feature works on new checkins you create from now on, and on not-yet initialized past checkins (i.e. the ones for days which you've never clicked on, if any)

from flaredown.

algodave avatar algodave commented on June 27, 2024

@lmerriam oh by the way, if you want to test on some past day, I can manually remove your existing checkins; just give me the dates in case you want to do that

from flaredown.

lmerriam avatar lmerriam commented on June 27, 2024

Gotcha! Makes sense. If you wanna clear the past 5 days of my check-ins that would be awesome

from flaredown.

algodave avatar algodave commented on June 27, 2024

@lmerriam Done!

from flaredown.

lmerriam avatar lmerriam commented on June 27, 2024

@algodave getting the same thing i got before, it seems to be targeting the wrong dose. right now i added a "5mg" dose of prednisone in the days you recently cleared for me, then the next day I turned on prednisone and the auto-dose was "3mg". I have used 3mg before, but not the prior day. Any way I can help diagnose?

from flaredown.

lmerriam avatar lmerriam commented on June 27, 2024

video, in case I'm doing something weird again: https://www.dropbox.com/s/0wzv58dlcdj0p4c/autoTreatmentDose2.mov?dl=0

from flaredown.

algodave avatar algodave commented on June 27, 2024

No, this time you're not doing anything weird :)
Let me better investigate tomorrow, I'm reopening.

from flaredown.

lmerriam avatar lmerriam commented on June 27, 2024

Random UX thought: if the last dose was "no dose" the auto dose should be "no dose"

from flaredown.

algodave avatar algodave commented on June 27, 2024

Oh this is important, thanks for posting! At the moment it's ignoring both null and blank values while retrieving the most recent. I'll change that.

from flaredown.

algodave avatar algodave commented on June 27, 2024

@lmerriam You can now test again; let me know which days should I delete checkin for you, if needed.

from flaredown.

lmerriam avatar lmerriam commented on June 27, 2024

Works for me! Closing 👍

from flaredown.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.