Comments (4)
Now Ruby on Rails
section of README
includes a note on turbolinks compatibility with quick fixes examples.
Let me know, please, if it should be reworded better or anything is missing.
from material_design_lite-sass.
Hello,
Thanks for the PR, but turbolinks compatibility fix probably shouldn't be hacked into actual MDL code, unless MDL team decides to natively support turbolinks.
Calling componentHandler.upgradeDom()
from material.js
file wouldn't solve the turbolinks issue for those, who chose modular JavaScript components load, for example. And for those projects without turbolinks extra calls are redundant.
But thanks for bringing attention to this subject, this is definetly a major use case for developers using this gem and I will add a note in README
with basic code examples for turbolinks v2/5 fixes.
from material_design_lite-sass.
Great point. I shouldn't have thrown my quick hack in a pull request. I've never made a gem before so I'm not sure how you would perform an "if using turbolinks then do..."
from material_design_lite-sass.
It would be good to add your change to the docs.
On Jul 29, 2016 9:46 PM, "John" [email protected] wrote:
Great point. I shouldn't have thrown my quick hack in a pull request. I've
never made a gem before so I'm not sure how you would perform an "if using
turbolinks then do..."—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#10 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAQtkm4s1IlFhqfYWPchnZhWRuVrmLLMks5qarr2gaJpZM4JYayz
.
from material_design_lite-sass.
Related Issues (10)
- svg files not included HOT 1
- Rspec Tests Failing after adding @import 'material' to application.css.scss HOT 1
- Ruby sass is deprecated - move to sassc gem? HOT 2
- Method of inclusion for color variables HOT 3
- Not display correctly on Safari HOT 14
- error when precompile assets (v1.0.4.1) HOT 9
- add template generators HOT 1
- Sass::SyntaxError: Expected a color. Got: rgb(63,81,181) HOT 1
- DEPRECATION WARNING: You are using the a deprecated processor interface HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from material_design_lite-sass.