builtin::true and builtin::false

[rohanc]

builtin::true and builtin::false

[rurban]

Thanks for the good test cases.
Many people do have different opinions about this. But JSON::PP should be matched

[rurban]

so encode should detect builtin::true, and decode optionally on core_bools

[karenetheridge]

so encode should detect builtin::true, and decode optionally on core_bools

That sounds reasonable to me. I expect that most of the time decoding to a core bool would make sense, but there might be a reason why it should be disabled (e.g. to cope with older code that looks explicitly for JSON::PP::Booleans?) so leaving a way to turn it off would be good.

[rohanc]

I agree with @karenetheridge that it would be useful to control the decoding behaviour. Both JSON::PP and JSON::XS allow this via the boolean_values method.

If this gets adopted and the default is off, I'll be looking for a way to turn it on globally, especially when I'm using tools like Mojolicious, where Cpanel::JSON::XS is used internally.

[karenetheridge]

I have prepared support in JSON::MaybeXS to support recognizing core booleans in its is_bool() interface, but I will wait until Cpanel::JSON::XS supports them before releasing -- otherwise, there might be surprising behaviour due to the mismatch of the results of is_bool() and serializing those booleans.

[rurban]

Yes, the boolean_values method will also be in, to provide the same API as JSON::PP. I'm just a bit too busy right now

[rurban]

I"ve delayed this feature for the 4.37 fixes for the 5.38 release, because I couldn't get it right yet. XS specialist help appreciated. I took the JSON::PP t/core_bools.t as reference.

[leonerd]

XS specialist help appreciated

Any specific questions or advice required?

[leonerd]

Any further thoughts here? I'm in the middle of writing some slides to present to FOSDEM, about how Perl has had proper boolean support since 5.36 and "all the serialisation modules will cope", except that I'm finding that most of them still don't. It'd be great to have this sorted and fixed.

I draw specific attention to my question above; namely:

XS specialist help appreciated

Any specific questions or advice required?