getenv_s problems with NULL terminator?

[aidan-copeland]

getenv_s problems with NULL terminator?

[rurban]

Well, I would argue that numberOfElements is the len, not the size, and their usage example is wrong. Or their docs.

But I'll check what the standard says, and how it's used in the wild.

The standard says:
the values of the environment variable is written to the user-provided buffer value (unless null) and the number of bytes written is stored in the user-provided location *len (unless null). If the environment variable is not set in the environment, zero is written to *len (unless null) and '\0' is written to value[0] (unless null).

and

len - pointer to a user-provided location where getenv_s will store the length of the environment variable.

So they return the len, not the size.

[rurban]

Ok, so how about returning the size on windows, and the length on standard-conforming platforms?

[rurban]

Implemented with the _WIN32-specific non-standard len+1.
This is the most widely used implemention. And all github code samples ifdef _WIN32