Shares converted to mnemonic form intermittently fail to recombine

[rust-bitcoin]

Shares converted to mnemonic form intermittently fail to recombine

[stevenroose]

I think the license of this project allows you to do that if you would like :)

…

On Mon, Mar 15, 2021 at 6:00 PM David ***@***.***> wrote: Just FYI this crate is linked as an implementation of SLIP-0039 from: https://github.com/satoshilabs/slips/blob/master/slip-0039.md. I agree it would be nice to pull SSS & SLIP-0039 out of the bitcoin_wallet crate and into its own home. It's much cleaner that way and a separate concern. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#27 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGQLXGMWDD2WZJWW5RJ45DTDZDLRANCNFSM4XROUNWQ> .

[stevenroose]

For BIP39 mnemonics, it's probably better to use https://github.com/rust-bitcoin/rust-bip39.

[dcow]

Sure, but this code still doesn't appear to work as demonstrated by the test case.

EDIT
Just to make sure you understand the scenario: I am splitting and recombining a seed using a 2,3 scheme not simply trying to roundtrip a seed to mnemonic and back using a 1,1 "split".

[dcow]

Actually, I'm not sure how BIP39 could even be used in place of the test case I have provided here. The only API exposed by this crate to serialize a SLIP-0039 share involves taking the mnemonic representation of the share. The Share struct, while public, doesn't offer any functions to convert to a vector or slice of u8 in the fixed format specified in slip0039. Are you suggesting that to_mnemonic is deprecated and we should be manually serializing the Share struct and then sending it though your rust-bip39 crate? Why not just update to_mnemonic to use rust-bip39?

[stevenroose]

Oh sorry I missed that you were talking about the SSS feature of this crate. I'm sorry to say that I have actually never looked at it. I took over maintenance from the previous maintainer of this crate. Tbh I spent some time in the past thinking about refactoring a lot of stuff in here and the shamir stuff would be one of the first things to go as it's really not required to build a bitcoin wallet.

[dcow]

Just FYI this crate is linked as an implementation of SLIP-0039 from: https://github.com/satoshilabs/slips/blob/master/slip-0039.md. I agree it would be nice to pull SSS & SLIP-0039 out of the bitcoin_wallet crate and into its own home. It's much cleaner that way and a separate concern.