Comments (5)
Small tweaks like this fall within the "semver compatible" vision of Rust because a small local annotation can be used to fix any compile errors. Additionally the changes provided are required for correctness, so it's possible to lead to memory unsafety if these aren't fixed.
from libc.
Small tweaks like this fall within the "semver compatible" vision of Rust because a small local annotation can be used to fix any compile errors.
I'm not sure what annotation you are referring to here, but if it's setting the dependency "^0.1.8", that does not work because Cargo assumes 0.1.9 is compatible with 0.1.8. If you mean setting the dependency "=0.1.8", that does not work because Cargo appears to be broken.
Additionally the changes provided are required for correctness, so it's possible to lead to memory unsafety if these aren't fixed.
Absolutely, and thank you for making the fix. My only concern is that the minor version was not bumped.
from libc.
I've yanked 0.1.9 and this can be discussed later.
from libc.
@danburkert - if there are really "breaking changes", it's not even enough to bump the minor version. The major version should also be adjusted, according to the link you posted.
However, it is also stated here (SemVer spec) that:
Major version zero (0.y.z) is for initial development. Anything may change at any time. The public API should not be considered stable.
So 0.1.9 being incompatible with 0.1.8 is perfectly fine in that sense. Still, all breaking changes should of course be thought through nonetheless (to avoid messing up for people), and even more and more as the usage of the library increases. My $0.02. 😄
from libc.
Is this discussion ongoing somewhere?
from libc.
Related Issues (20)
- Hostname on xtensa esp-idf esp32s3 HOT 3
- Unnecessary `unsafe` for `libc::major` and `libc::minor`? Or is `libc::makedev` missing unsafe?
- preadv2 is not supported on musl libc HOT 2
- Missing kill function in libc on Windows HOT 8
- The getppid function is missing on Windows HOT 4
- Missing POSIX confstr and _CS_* symbols on Linux. HOT 7
- cannot find value `SETVAL` in crate `libc` HOT 3
- Build script does not respect RUSTC_WRAPPER
- TCP_NODELAY has the wrong value on ESP32 (newlib / LWIP based)
- MODULE_INIT_COMPRESSED_FILE is missing for linux
- libc crate triggers warnings when compiled with `default-features = false, features = ['rustc-dep-of-std']`
- Policy issue: libc CI should not include tier 3 targets HOT 1
- Policy question: changes for platform consistency HOT 4
- Breaking Android changes for libc 1.0 HOT 1
- Discussion about removing `extra_traits` in 1.0 HOT 1
- uclibc/mips change `SA_*` to `uint` HOT 5
- Add NetBSD to CI
- Uncommenting SO_PREFER_BUSY_POLL and SO_BUSY_POLL_BUDGET HOT 2
- Move away from 2015 edition? HOT 7
- Different behaviour between `libc::poll` and calling `poll` in C directly on linux. HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from libc.