Comments (6)
Thanks for fixing this. Much appreciated.
Here is my commit where I migrate to the newest linfa
version. It was really tricky. I had a wrong assumption about Cargo.toml
, when specifying version="*"
, that the newest version would be used, but instead I ended up with a mix of both the newest linfa and an older linfa, causing weird error messages. These were the versions I had:
linfa
=0.7.0
linfa-logistic
=*
, which resolved to version0.6.1
linfa-preprocessing
=*
, which resolved to version0.6.1
Setting the same version for all the linfa
packages, and now it compiles fine. Had I done that from the beginning, then it would have been easy to fix.
from linfa.
Hello @YuhanLiin
I'm interested in contributing to this open source project. However, I'm not entirely clear on what this issue entails and would greatly appreciate some clarification.
Could you please provide me with more information about the issue and what specifically needs to be done to resolve it? I'm eager to learn and contribute in any way I can.
thank you
from linfa.
So linfa-ftrl
and linfa-logistic
both depend on argmin
0.4.6 and linfa-linear
has argmin
0.7. I'd like the argmin
version on all three crates to be bumped up to 0.8, and argmin-math
should be bumped to 0.3. The change should be trivial on linfa-linear
, but will be more involved on linfa-logistic
and linfa-ctrl
, since they require code changes. You can refer to #289, which bumped argmin
in linfa-linear
to 0.7, for guidance on what to change in the other two crates.
The reason why I want to upgrade argmin
is because newer versions of argmin
have serde
as an optional dependency, whereas serde
was mandatory in older versions. This in turn allows linfa-ftrl
and linfa-logistic
to have serde
as optional, which is consistent with the other Linfa crates. Again, you can refer to #289, which also made serde
optional in linfa-linear
.
from linfa.
I planned to update linfa-ftrl
and linfa-logistic
as well but unfortunately I won't be able get to it anytime soon. I may however be able to provide guidance and help if needed. Feel free to ping me if there is anything I may be able to help you with.
If I recall correctly, the changes necessary in linfa-ftrl
should be fairly similar to the ones made in linfa-linear
. I think linfa-logistic
may be a bit more complicated.
from linfa.
Hi can I be assigned this issue? I've already got linfa-linear to work, and started to work on linfa-logistic, but it seems like argmin massively changed its trait structure and no longer has directly declared operators(ArgminSub,ArgminAdd, etc.). There is the Operator trait that might be relevant? but I'm not sure how to propagate it and if it would break things. I'm new to Rust but want to help!
Thanks!
from linfa.
whoops, looks like I got ahead of myself, I didn't get linfa-linear
working, sorry about that
from linfa.
Related Issues (20)
- Would there be any interest in a Covariance module? HOT 2
- How I can save a logistic model for serving? HOT 6
- linfa-clustering depends on partitions 0.2.4, which throws future-incompatibilities warnings HOT 1
- Incompatibility of the partitions dependency with future versions of Rust HOT 3
- Shuffle dataset HOT 2
- Implementing serde Serialize/Deserialize for linfa_bayes crate models HOT 1
- Standard error estimation on OLS coefficients HOT 3
- linfa-kernel fails to compile HOT 10
- linfa-svm learning speed and memory allocation
- Dependency version thiserror in linfa hierarchical causes problems in real world projects
- Crates.io version of linfa_kernel fails to compile. HOT 1
- Would it be better to use the same API as scikit-learn HOT 2
- Serialize a trained model to disk? HOT 2
- Is the `nu` parameter used incorrectly, for svm regression? HOT 1
- [Proposal] Gaussian Mixture Models HOT 1
- Discrepancy in GMM covariance between sklearn and linfa HOT 1
- add tag and github release of version 0.7.0
- Let linfa_linear::LinearRegression support weights from a dataset
- MultiLogisticRegression panics on normalized data.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from linfa.