The oaep padding is not compatiable to other lib.

[rustcrypto]

The oaep padding is not compatiable to other lib.

[dignifiedquire]

• the online tool seems to only support oeap with sha1, but your rust code shows using sha2
• the default in nodejs is sha1 one as well see https://nodejs.org/api/crypto.html#crypto_crypto_privatedecrypt_privatekey_buffer

  oaepHash The hash function to use for OAEP padding and MGF1. Default: 'sha1'

[wenjoy]

@dignifiedquire Thanks for rapidly reply. I thought is the sha1 issue. But I cant figure out how to use sha1 in this crate.

use rsa::{PublicKey, RSAPublicKey, RSAPrivateKey, PaddingScheme};
use rand::rngs::OsRng;
use sha1::Sha1;

pub fn encrypt_(key: &[u8], plaintext: &[u8]) -> Vec<u8> {
  let mut rng = OsRng;
  let data = plaintext;
  let public_key = RSAPublicKey::from_pkcs8(key).expect("get private key error");
  // pkcs#1 padding
  // let padding = PaddingScheme::new_pkcs1v15_encrypt();
  let padding = PaddingScheme::new_oaep::<Sha1>();
  let enc_data = public_key.encrypt(&mut rng, padding, &data[..]).expect("failed to decrypt");
  enc_data
}

I tried this, but it complain. And I cant find out what other than Sha256 I can adapt, after go through the document.

[tarcieri]

Note: SHA-1 is cryptographically broken and unsuitable for use in any secure context.

[wenjoy]

@tarcieri Thanks. But I do need to interact with some legacy code. Is there any way I can use this lib to achieve?

[dignifiedquire]

@wenjoy what is the issue you are encountering with passing Sha1? We do have a test making sure the code does work with Sha1: https://github.com/RustCrypto/RSA/blob/master/src/key.rs#L904

[wenjoy]

@dignifiedquire I got this error:

the trait bound `sha1::Sha1: digest::Update` is not satisfied

the trait `digest::Update` is not implemented for `sha1::Sha1`

But the link you post inspired me to check the dependencies, then I solved it!

Thanks so much @dignifiedquire !

That's the thing. Previously my dependencies likes this:

sha1 = "*

after compare with this lib's , I found it should be this:

sha-1 = "*"

Now it works like a charm. But I have to say why its name so weird. Just following sha2 sha3 wouldn't be nice?

Anyway, thanks again @dignifiedquire.

[newpavlov]

@wenjoy
See the following remark in the hashes repository: https://github.com/RustCrypto/hashes#crate-names

[dignifiedquire]

glad to hear it is working now @wenjoy

[wenjoy]

@newpavlov Now that does make sense. Thanks buddy.