Tiny memory leak in `rustler_export_nifs`

[rusterlium]

Tiny memory leak in `rustler_export_nifs`

[hansihe]

CString::into_raw transfers ownership, so it is safe in that sense.

The way it's done currently does cause the string to leak however, so your suggestion is probably a better idea here

[jorendorff]

OK, rev db0cfeb is the fix for this.

[goertzenator]

@hansihe Is this completely leak free now? If so I'd like to retract erlang/otp#1294 which has technical problems that I did not foresee. Upcoming Rust macro features in the next year or 2 should resolve the Rust-side limitations I experienced.

[hansihe]

@goertzenator No, it is still not completely leak free. The leak is not very large however, and it only happens on a NIF unload, so we are probably fine either way. You decide if you want to retract the PR.

[jorendorff]

@hansihe Where do we still leak memory?

[hansihe]

@jorendorff Isn't this leaking memory? There is nothing dropping that.

[goertzenator]

entry gets moved into NIF_ENTRY which is static. I've looked closely at this file and I'm not seeing leaks.

[hansihe]

@goertzenator Ah, I forgot how static variables worked for a second. There is indeed no leaks.