Giter Site home page Giter Site logo

Comments (11)

rusty1s avatar rusty1s commented on June 15, 2024

Thanks for reporting. I will look into it. I guess python setup.py test also fails for you?

from pytorch_cluster.

EricGz avatar EricGz commented on June 15, 2024

Thank you for looking into it! You are right. The test failed.

from pytorch_cluster.

rusty1s avatar rusty1s commented on June 15, 2024

Do all GPU tests fail?

from pytorch_cluster.

EricGz avatar EricGz commented on June 15, 2024

Yes, I think so. 55 failed and 56 passed. All the failed ones are GPU tests.

from pytorch_cluster.

rusty1s avatar rusty1s commented on June 15, 2024

Ok, so this is not a problem with the random walk function, but the installation of torch-cluster. Can you post the log of

rm -rf build && python setup.py install

from pytorch_cluster.

EricGz avatar EricGz commented on June 15, 2024

Here's the log. log.txt

from pytorch_cluster.

EricGz avatar EricGz commented on June 15, 2024

It seems the whole installation goes fine. However, I still get wrong results running random walk on GPU. Do you have any idea what went wrong?

from pytorch_cluster.

rusty1s avatar rusty1s commented on June 15, 2024

Unfortunately no :( Logs look okay to me. Maybe you have multiple versions installed where one installation failed? You can try removing torch-cluster repeatedly and install again.

from pytorch_cluster.

EricGz avatar EricGz commented on June 15, 2024

Hi, @rusty1s, thanks for your timely reply. I tried your suggestion, but the problem is still unsolved.

I tried some other tests and got more information about this error. When I used the GPU version of scatter_max and scatter_min in package torch_scatter, I met this error again, and the interesting thing is that the GPU version of functions' like scatter_add and scatter_mean worked fine.

Maybe there's something common about scatter_max and random_walk that caused the error?

P.S. Here's the test results of scatter_max and scatter_add

import torch
from torch_scatter import *

# device = 'cpu'
device = 'cuda:1'

src = torch.tensor([[1., 1.], [1., 1.], [4., 2.], [2., 4.]]).to(device)
index = torch.tensor([0, 0, 1, 1]).to(device)
index = index.view(-1,1).repeat(1,src.size()[1])

res1, _ = scatter_max(src, index, dim=0, fill_value=1.)
res2 = scatter_add(src, index, dim=0, dim_size=2, fill_value=0.)

print(res1)
print(res2)

The results are

tensor([[1., 1.],
        [1., 1.]], device='cuda:1')
tensor([[2., 2.],
        [6., 6.]], device='cuda:1')

I tried to debug it and I found that line 13 func(src, index, out, arg, dim) of max.py did not change the variable out at all. Do you have any clue about what caused the problem?

from pytorch_cluster.

rusty1s avatar rusty1s commented on June 15, 2024

Yeah, those are the functions that call our own kernel implementations. It seems that there is something wrong with you GPU setup in conjunction with the provided cuda code.

from pytorch_cluster.

github-actions avatar github-actions commented on June 15, 2024

This issue had no activity for 6 months. It will be closed in 2 weeks unless there is some new activity. Is this issue already resolved?

from pytorch_cluster.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.