Giter Site home page Giter Site logo

Comments (3)

albertz avatar albertz commented on June 16, 2024

Question on StackOverflow, without a real answer yet, though. However, after some short research, I think sth like this could work:

Maybe via the branch protection rules. I saw some examples that the branch protection rules can include custom status checks. The status checks, these are GitHub actions. So I could maybe add a custom GitHub CI action which checks for a valid commit (valid = any changed file is below the size limit).

from returnn-experiments.

albertz avatar albertz commented on June 16, 2024

I have put some initial code for a GitHub action using adobe/sizewatcher but I'm not really sure whether that can work. Some issue: adobe/sizewatcher#79

Maybe this can not really work like this. The GitHub action runs for pushes, but actually only after the push already has been done, but then it is too late already. It should check it before the push completes and the push itself should fail if this check fails. I'm not sure this is really possible.

I think sizewatcher actually expects that this is done for PRs and it compares to the master branch. Then we would only allows PRs where these checks are passing, and also we would not allow direct pushes to the master branch anymore.

from returnn-experiments.

albertz avatar albertz commented on June 16, 2024

I also asked for such a feature now in the official GitHub community forum.

from returnn-experiments.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.