Giter Site home page Giter Site logo

Comments (7)

rxi avatar rxi commented on June 27, 2024 1

I'd be happy to merge the change with one minor modifcation: lite provides a PLATFORM global for these situations; the package.config check can be replaced with the following:

if PLATFORM == "Windows" then

from lite-plugins.

rxi avatar rxi commented on June 27, 2024

As far as I know windows doesn't provide a dictionary file similar to linux, you'll have to download the dictionary file you want to use. You can then place it next to lite.exe and set the relevant config field inside your user module:

config.dictionary_file = EXEDIR .. "/dictionary_filename"

from lite-plugins.

mundusnine avatar mundusnine commented on June 27, 2024

Noted; Looking into available dictionary files that we could use to propose to windows users. Maybe putting a note in the readme recognizing this issue on windows would be valuable to avoid people like me to report the issue ;)

from lite-plugins.

mundusnine avatar mundusnine commented on June 27, 2024

My guess is we could use this: words.txt file ? I looked around the interwebs and the words file on linux just seems to be a newline-delimited list of dictionary words.

from lite-plugins.

rxi avatar rxi commented on June 27, 2024

Yep, any white-space-separated list of words will work

from lite-plugins.

mundusnine avatar mundusnine commented on June 27, 2024

Would you find it adequate to change:
config.dictionary_file = "/usr/share/dict/words"
to

if package.config:sub(1,1) == '/' then
  config.dictionary_file = "/usr/share/dict/words"
else
  config.dictionary_file = EXEDIR .. "/words.txt"
end

As this would enable windows users to just include a words.txt file and spellchecking would work ?

Btw I intend on doing a PR to change the readme to note what I said before(i.e. on windows we need to supply a words.txt) and I would add the change I just talked about if you approve.

from lite-plugins.

mundusnine avatar mundusnine commented on June 27, 2024

Will be closed by this: #42

from lite-plugins.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.