Comments (9)
I have submitted a pull request #50 which solves the issue described above.
from react-localize-redux.
Thanks for the PR. I will have a closer look when I get some time, but in the meantime if you used plain old connect
instead of the Localize
HOC like it's shown here would that get around the issue you're having?
from react-localize-redux.
Yes it does solve the problem, I wanted to avoid using connect in our app as we have a lot of smaller components. Although I was going to suggest that devs prefer passing translations as props rather than using Localize everywhere, as per your docs.
I would still rather use Localize HOC as its a bit cleaner and I can see other devs abusing connect if they see it being used in places where we otherwise wouldn't.
Its a fair point though and something I will consider as our project progresses.
Thanks.
from react-localize-redux.
One thing to keep in mind is that Localize is just a facade around connect
. So connect
can still be abused by overusing Localize as well. You got the right idea though with passing translations down to child components.
from react-localize-redux.
Confirmed fix from #50. This is available in v2.15.0.
from react-localize-redux.
Great thanks!
from react-localize-redux.
Hi, I would like to reopen this issue, it appears that my fix does not in fact work after all, I misunderstood quite what an immutable Map was, and also didn't test this on my own app properly, as it was still in early development, apologies for that.
In order to check this correctly we need to import the Immutable Map object and do Map.isMap()
. I have tested this in my own app using Immutable for the root state, with the localize HOC and this works as expected.
from react-localize-redux.
Pull request submitted. #57
Thanks for your time and sorry about this!
from react-localize-redux.
Fixed in #58 and released in v2.16.0
from react-localize-redux.
Related Issues (20)
- translate function not returning proper type [with CodeSandBox example]
- Translation returns [Object object]
- LocalizeContext not declared in types declaration despite being exported HOT 2
- onMissingTranslation for multiple translations HOT 1
- Translating external components HOT 1
- Falling back to a translation that has html in it causes a crash
- Unit test for the Translate Component in Demo HOT 1
- [Bug] onMissingTranslation is a non-serializable value HOT 1
- Translate component not working with options { defaultLanguage: "XX" }
- License issue with dependency: create-react-context ^0.2.2 (resolves to 0.2.3) HOT 1
- Denial of Service Node Fetch HOT 1
- Fallback option for default language when using translate() function
- Performance with big translation file HOT 1
- Getting value to populate to render block without triggering warning
- Import "InitializePayload" fails in esbuild (e.g. when using Vite) HOT 3
- Update react peer dependency HOT 4
- Type mismatch when using redux toolkit with Typescript
- Vulnerabilities in the latest react-localize-redux HOT 8
- Localize.on "initialize" never fires
- This package is dead, replacement?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from react-localize-redux.