Giter Site home page Giter Site logo

Crash in ios about just_audio HOT 7 CLOSED

yringler avatar yringler commented on July 4, 2024
Crash in ios

from just_audio.

Comments (7)

ryanheise avatar ryanheise commented on July 4, 2024

It could be that _eventSink hasn't been initialised yet, so that method may need to have a guard like this:

if (!_eventSink) return;

I also have a lot to learn about iOS memory management still, so maybe it's something even more crazy like the self instance being free'd. But I'd start with the above guard first. In any case, I am going off to sleep now. You are of course welcome to try the above code suggestion and see if it works for you in the meantime, assuming you are able to reproduce the issue.

from just_audio.

yringler avatar yringler commented on July 4, 2024

Thank you! When the plugin is updated I'll use it and redeploy, and see if that stops this crash.

from just_audio.

ryanheise avatar ryanheise commented on July 4, 2024

I've added the above line of code to the latest git commit if you'd like to test it.

from just_audio.

jonafeucht avatar jonafeucht commented on July 4, 2024

I've added the above line of code to the latest git commit if you'd like to test it.

Thanks! App works like a charm now. Would recommend releasing as fast as possible as this is quite the critical error on iOS

from just_audio.

ryanheise avatar ryanheise commented on July 4, 2024

Great! I was waiting on confirmation on some other iOS code that will also be included in the release, but it seems that things are working well enough that you haven't noticed any issues so I've just published a new release. If you have some spare time, I would also appreciate your feedback on #35 .

from just_audio.

yringler avatar yringler commented on July 4, 2024

It's been 24 hours, and I'm not seeing any crashes now that I'm using the latest commit.

One interesting bit of context: One beta tester showed me that the crash happened when

  1. audio was playing,
  2. he sent voice note in whatsapp

from just_audio.

github-actions avatar github-actions commented on July 4, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs, or use StackOverflow if you need help with just_audio.

from just_audio.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.