Giter Site home page Giter Site logo

Comments (6)

schoenwaldnils avatar schoenwaldnils commented on May 5, 2024

Thats why I opened a PR #51
Maybe this issue is a duplicate to #31 ?

from clean-code-javascript.

arayi avatar arayi commented on May 5, 2024

How is that addressed in PR #51 ?

See https://github.com/ryanmcdermott/clean-code-javascript#use-es6-constants-when-variable-values-do-not-change

This section seems to convey that const is for immutable values. "If the value changes, I change it to let" in #31 also seems to convey that const is for immutable values. So someone unfamiliar with how it is implemented may accidentally code something that modifies their const without reassigning it (which DOES work, unlike reassigning), and become very confused.

But no, this is not addressed in either of those.

from clean-code-javascript.

schoenwaldnils avatar schoenwaldnils commented on May 5, 2024

Sorry, I misunderstood that the issue is about this paragraph.
True, my PR just fixes the use of let and const in the readme itself.

The paragraph has to be rewritten, of course.

from clean-code-javascript.

tonytran1 avatar tonytran1 commented on May 5, 2024

That's true, const properties can be changed and are mutable. The section was referring to primitive values of declared constants. Of course that's not their only use. Please update it to your understanding. Thanks.

from clean-code-javascript.

ryanmcdermott avatar ryanmcdermott commented on May 5, 2024

Thanks Arayi! You're right that the paragraph doesn't do the best job explaining the nature of the keyword const I think we should link to @mathiasbynens and @ericelliott for an authoritative educational stance on this. I would love a PR to accompany @schoenwaldnils awesome work!

from clean-code-javascript.

ryanmcdermott avatar ryanmcdermott commented on May 5, 2024

This subsection was removed for the time being, until we come up with a better explanation for when to prefer const and how it helps improve refactorability.

ac47e82

from clean-code-javascript.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.