Giter Site home page Giter Site logo

Comments (11)

Finii avatar Finii commented on June 11, 2024 1

Where is the PR @Finii !!!?

from nerd-fonts.

gibfahn avatar gibfahn commented on June 11, 2024 1

Thanks for the detailed explanation and the solution! I don't know if it's helpful, but I filed your proposed solution as a PR. I think that's right, don't have much experience in this area. #1617

It's your change, so if you want to file your own PR for it fine by me, just trying to reduce some cycles for you 😁 .

from nerd-fonts.

Finii avatar Finii commented on June 11, 2024 1

Most probably you already read it, but if not... the cryptic rules have some explanation

# Stretch 'xz' or 'pa' (preserve aspect ratio)
# Supported params: overlap | careful | xy-ratio | dont_copy | ypadding    
# Overlap value is used horizontally but vertically limited to 0.01
# Careful does not overwrite/modify existing glyphs
# The xy-ratio limits the x-scale for a given y-scale to make the ratio <= this value (to prevent over-wide glyphs)
# '1' means occupu 1 cell (default for 'xy')
# '2' means occupy 2 cells (default for 'pa')
# '!' means do the 'pa' scaling even with non mono fonts (else it just scales down, never up)
# '^' means that scaling shall fill the whole cell and not only the icon-cap-height (for mono fonts, other always use the whole cell)
# Dont_copy does not overwrite existing glyphs but rescales the preexisting ones
#
# Be careful, stretch may not change within a ScaleRule!
'align': 'c', 'valign': 'c', 'stretch': '^pa1!', 'params': {'ypadding': 0.3, 'careful': True}
  • Align horizontally and vertically in the center
  • Scale it with preserved aspect ratio (x and y scale is equal) into 1 cell (default would be 'up to 2' for pa)
  • Take the whole line-hight (^) and subtract 30% from the height (ypadding)
  • Do the scaling also for proportional fonts
  • Do not change preexisting glyphs

from nerd-fonts.

Finii avatar Finii commented on June 11, 2024

Sorry to hear of your size problem.

I can see it directly in the font 🤔

image

Suspect

Because from these heavy brackets people DO expect excessively big icons 🤔

from nerd-fonts.

Finii avatar Finii commented on June 11, 2024

In this example the icon is (far) less tall than the small letter T, which is strange

image

I will example in detail.

from nerd-fonts.

Finii avatar Finii commented on June 11, 2024

The cell heights difference is quite huge here?

image

image

Not the case 'globally':

image

image

68% vs 76% ?

Hmm, thanks for reporting. This needs some consideration and a systematic check. I see the effect by the reason is not quite clear; and maybe that should have been marked with the ^ (fit to full height) modifier.

from nerd-fonts.

Finii avatar Finii commented on June 11, 2024

Ahh, one should read ...

image

from nerd-fonts.

Finii avatar Finii commented on June 11, 2024

Ah, the heavy brackets are now two times shrunken, there was an old rule that already sized them down relative to the full cell:

image

The rule needs to be changed to ^pa1! ....

from nerd-fonts.

Finii avatar Finii commented on June 11, 2024

@allcontributors please add @gibfahn for bug

from nerd-fonts.

allcontributors avatar allcontributors commented on June 11, 2024

@Finii

I've put up a pull request to add @gibfahn! 🎉

from nerd-fonts.

martinpelikan avatar martinpelikan commented on June 11, 2024

Apologies if this is unrelated or intended, but I noticed an increase in the size of some symbols in ttf-firacode-nerd, going from 3.2.0 -> 3.2.1 in my i3 status bar.

3.2.0 3.2.1
2024-04-18_19-08 2024-04-18_19-09

U+F120 (nf-fa-terminal) and U+F11B (nf-fa-gamepad)

from nerd-fonts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.