Debugger crash when script call process.exit()

[mik01aj]

Debugger crash when script call process.exit()

[s-a]

Can you setup a simplified project to reproduce the error and create a repo at github? I d like to inspect this.
Never Seen this before. Looks like a crash in chromium.

[s-a]

Are you spawning processes there? Maybe there are more infos in your terminal console log.

[mik01aj]

I created a small example: https://gist.github.com/mik01aj/873aa20f73716f626738

[s-a]

Thanks. You are running iron-node suite.js right? I will test this this evening

[mik01aj]

Yes.

[s-a]

OK.
I was able to run the test suite.

And I was able to debug the test suite.

Jasmine calls process.exit which seems to cause a crash.

This hot fixes the issue.

process.exit = function() {}

Well this should impact other Libraries too so I need to overwrite process.exitand output exitcode to console.

[s-a]

Can you confirm that ? I updated your gist at https://gist.github.com/s-a/aaec29ad03cd7138ca8a#file-suite-js-L10

[s-a]

Regarding the strange console log I created a ticket at electron/electron#2390.
We should change the issue title because there is nothing you can debug there 😸

[s-a]

In case of a script calls process.exit() you will see now a toaster as notification. This is much more fun 😃

[mik01aj]

Nice!

I have one more idea: maybe system.exit should be mocked with function () { debugger; }?

[s-a]

I think that's something users should decide for themselves. For some people it could be irritating. You can create packages very easy to implement your desired behavior.

An example package is here
https://github.com/s-a/iron-node-zerodarkmatrix-theme/blob/master/index.js. I would love to See various mutations of addons at the package channel.

[mik01aj]

How about this example?

setTimeout(function () { process.exit(); }, 1000);
setTimeout(function () { console.log('You will never know what I wanted to tell you'); }, 1001);

Will the message show up in iron-node? I think it will, and imho it shouldn't.

[s-a]

Yes it is a little bit weird. Would be nice to find a way to stop script execution if exit was called which is far from trivial. Seems you found a limitation here.

[mik01aj]

When you put a breakpoint there, it becomes trivial :) And you can put the real process.exit after it so that these strange situations will not happen.

A breakpoint at exit is very useful imho, because then I am able to inspect whole application state at exit. Think about a command/line script. It can have process.exit() on the end or not, it's roughly equivalent (minus waiting for any pending calls from setTimeout, setInterval, process.nextTick, Promises or similar async mechanisms). I think that they should be "roughly equivalent" in the debugger as well, so that in both these cases (I mean a. scripts exititing explicitly using proces.exit and b. scripts exiting implicitly by finishing executing the main script and emptying the event loop):

1. the process behaves the same both in normal runtime and in debugger
2. it is easy to debug post-mortem state of the process.

[s-a]

We can not avoid the situation. process.exit will cause a crash because everything is based on node. Anything beyond process.exit will exit the GUI application.
So far there is no way to detect script finished especially pending async methods done events.

[s-a]

@mik01aj check out https://github.com/s-a/iron-node-process-exit-break

[mik01aj]

It works great! Thanks! :)

[mik01aj]

I owe you a beer when I come to Hamburg!

[s-a]

👍 😄