s-fam / pyeonhaeng Goto Github PK
View Code? Open in Web Editor NEW편행(편의점 할인 행사 앱 프로젝트) v1.0
편행(편의점 할인 행사 앱 프로젝트) v1.0
Onboarding 화면에 기본 색상을 적용하다가 closed된 23번 PR(UIColor extension관련)에 개인적인 의견이 생겨 글 올립니다.
지난 pr인데 다시 얘기 꺼낸 점 죄송합니다ㅠ
기본 색상은 아래 사진에 보이듯이 네이비 색상에 가까운 색을 말합니다. (색상 코드 : #030026)
▼ 현재 UIColor+.swift의 코드
import UIKit
extension UIColor {
convenience init(hex: Int, alpha: CGFloat = 1.0) {
let components = (
red: CGFloat((hex >> 16) & 0xff) / 255,
green: CGFloat((hex >> 08) & 0xff) / 255,
blue: CGFloat((hex >> 00) & 0xff) / 255
)
self.init(red: components.red, green: components.green, blue: components.blue, alpha: alpha)
}
}
// MARK: - Store's SymbolColor
extension UIColor {
static let cuBackGroundColor = UIColor(hex: 0x51485)
static let cuFontColor = UIColor(hex: 0x9DC92A)
static let gsBackGroundColor = UIColor(hex: 0x63514D)
static let gsFontColor = UIColor(hex: 0x00D7F1)
static let seBackGroundColor = UIColor(hex: 0xFF8329)
static let seFontColor = UIColor(hex: 0x005B45)
static let msBackGroundColor = UIColor(hex: 0x003893)
static let msFontColor = UIColor(hex: 0xF0F0F0)
static let emBackGroundColor = UIColor(hex: 0x56555B)
static let emFontColor = UIColor(hex: 0xFFB41D)
}
편의점별 색상 코드가 중복되어있습니다.
편의점 별 색상코드는 UIColor+.swift
대신 CVSType.swift
에 통합하여 적용하는건 어떤가요? 여러분들은 어떻게 생각하시나요?
CVSType과 EventType Codable
을 준수하도록 변경하고 싶어요. Firebase에서 값을 가져올 때 만들어져있는 Enum을 재사용하는 게 좋을 거 같아서요!
A declarative, efficient, and flexible JavaScript library for building user interfaces.
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
An Open Source Machine Learning Framework for Everyone
The Web framework for perfectionists with deadlines.
A PHP framework for web artisans
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
Some thing interesting about web. New door for the world.
A server is a program made to process requests and deliver data to clients.
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
Some thing interesting about visualization, use data art
Some thing interesting about game, make everyone happy.
We are working to build community through open source technology. NB: members must have two-factor auth.
Open source projects and samples from Microsoft.
Google ❤️ Open Source for everyone.
Alibaba Open Source for everyone
Data-Driven Documents codes.
China tencent open source team.