Giter Site home page Giter Site logo

Comments (4)

s-leger avatar s-leger commented on June 26, 2024

Window direction depends on the orientation primary to boolean operation.
To estimate orientation, i do take a point 1 m behind window, and check if he's on left or right part of the wall's side you draw (side showing manipulators).

With perpendicular window at boolean time, they likely to rotate the wrong side (and as long as there is nearly no way to determine inside/outside from say unclosed wall, if you lucky they rotate the right side).
A linear analysis to see witch side is the longest may be part of the solution, but you'll always find edges cases where it fails.

So i must find a better way to determine default rotation.

Also such rule dosen't work with doors as opening direction may vary.

Seem logical to draw external part of the wall, but cant assume it will always be the case, and not enforce any CW or CCW way of drawing to set inside or outside.
Anothe issue is interoperability as some data-models use axis to define a wall.

There are then 2 set of params to handle inside/outside materials and drawing from borders or axis.

  • Inside / Outside for material, currently does affect windows and doors holes materials according too,
  • Offset from -1 to 1 to allow drawing from either border and axis.

from archipack.

mirlip avatar mirlip commented on June 26, 2024

As I'm not a native english speaker, to clarify:

  • for closed walls, we agree the solution can be automatic?
  • for other wall, user can define the inside/outside with the flip option. It could be used to rotate windows and such according to this? For cases where both direction make sens, they could also get a flip option.

from archipack.

s-leger avatar s-leger commented on June 26, 2024

At draw a wall time, and when closing a wall,
we may assume wich part is the inside and set flip when relevant.

At manipulate time, and boolean use the flip param to determine witch side is inside/outside and orient window according.

from archipack.

s-leger avatar s-leger commented on June 26, 2024

Fixed :
Window auto align to outside at boolean time, and when flip does change.
Full support for x_offset added too.

from archipack.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.