Giter Site home page Giter Site logo

Comments (5)

mkarg avatar mkarg commented on June 16, 2024

Should it really fail or should it just log a warning? Possibly a philosopic question.

from sign-maven-plugin.

mkarg avatar mkarg commented on June 16, 2024

I am neither a GPG nor Bouncy Castle expert, so I checked the API and it seems only public keys have an expiration date (secretKey.getPublicKey().getValidDays())?

from sign-maven-plugin.

slawekjaranowski avatar slawekjaranowski commented on June 16, 2024

IMHO for expired key we should break and report cause with reason
the same does gpg (but reason is only in verbose mode)

gpg -v --armo --sign -u B09391374A115DE2
gpg: Note: signature key B09391374A115DE2 expired Wed Dec 23 08:29:20 2020 CET
gpg: skipped "B09391374A115DE2": Unusable secret key
gpg: signing failed: Unusable secret key

from sign-maven-plugin.

mkarg avatar mkarg commented on June 16, 2024

Agreed. Do you know how to ask Bouncy Castle for the expiration date? I just cannot find that in the API docs. :-(

from sign-maven-plugin.

slawekjaranowski avatar slawekjaranowski commented on June 16, 2024

It is not easy - I know

my recipe - add test and in debug mode look at loaded pgp object, and look to bouncycastle source

useful will be look at pgp packets, by:

gpg --list-packets src/test/resources/priv-expired-key-no-pass.asc

I will try to do it today evening

from sign-maven-plugin.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.