Giter Site home page Giter Site logo

Comments (12)

s8sg avatar s8sg commented on July 24, 2024 1

I’ll check this over the weekend

from goflow.

s8sg avatar s8sg commented on July 24, 2024

I think by design it should not require a restart. If this is happening it can be a bug.

The idea is to define the workflow in each requests. Even for partial request

from goflow.

dan2li avatar dan2li commented on July 24, 2024

I think by design it should not require a restart. If this is happening it can be a bug.

I'm not quite sure, but it seems like the task queue and consumer for each flow are initialized in the StartQueueWorker function, which is only called once when the flow service is started. This is why a restart of the flow service is needed to make new flows effective.

from goflow.

dan2li avatar dan2li commented on July 24, 2024

The idea is to define the workflow in each requests. Even for partial request

Are you suggesting that after separating flow and workload, we can attach the complete flow information to each request? That's ok if there is also a method to dynamically register workloads.

from goflow.

dan2li avatar dan2li commented on July 24, 2024

Hi @s8sg ,how are things going? :)

from goflow.

Lucifer8729 avatar Lucifer8729 commented on July 24, 2024

hey @s8sg , this is very crucial for a workflow engine

from goflow.

s8sg avatar s8sg commented on July 24, 2024

@Lucifer8729 I would love to know why it’s crucial for a workflow orchestration. For example what kind of business use cases needs this and which other platform provides such support

Goflow supposed not to be a traditional workflow engine. It supposed to solve common use cases such as orchestrating a set of task that need to be executed in async reliably. I wanna stress on the reliability part because that is where I think the primary focus for this library should be

In my experience I have hardly came across use cases where you need to change the orchestration on the fly very often.

For not so common use cases I'll suggest to contribute to the repo so that we can close the high priority items and make progress for the additional requirement such as this

from goflow.

s8sg avatar s8sg commented on July 24, 2024

Duplicate of #66

from goflow.

dan2li avatar dan2li commented on July 24, 2024

@s8sg To clarify, the goal is not to dynamically change the orchestration during runtime, but to register a new flow, which is a different scenario from #66 . When I use goflow to create a workflow platform similar to Airflow, which allows users to dynamically define and submit new workflows, this is a necessary function.

from goflow.

s8sg avatar s8sg commented on July 24, 2024

@dan2li do you want to register the flow with a new name ?

from goflow.

s8sg avatar s8sg commented on July 24, 2024

I might have misunderstood. I think as long as we are not updating the existing workflow I’m fine to dynamically register a new workflow on the same flow service. Reopening the same

from goflow.

dan2li avatar dan2li commented on July 24, 2024

Awesome! @s8sg could you help to review #74 ? :)

from goflow.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.