Comments (4)
from cmp.
Hi @Zurga , thank you for the suggestion.
As you mentioned, this doesn't seem compatible with the performance goal of Cmp
's. Even as an option, checking options would be an overhead that is not so small for this kind of low-level operation.
Besides, all binaries have the same type and are indistinguishable, you don't know the encoding upfront.
I think there might be an elegant solution to achieve this though, just by defining custom structs and implement the Cmp.Protocol
for them.
defmodule MyString do
@type t :: %{string: String.t()}
defstruct [:string]
defimpl Cmp.Comparable do
def compare(%MyString{string: left}, %MyString{string: right}) do
alphabetical_compare(left, right)
end
def compare(left, right), do: raise(Cmp.TypeError, left: left, right: right)
end
end
(or %Book{title: String.t(), author: String.t()}
...)
- It would be safe to assume utf8 for these structs, unlike arbitrary binaries
- The performance of regular binary comparison would stay unaffected
- Actually doesn't even require any change in
Cmp
since it is extensible through the protocol
from cmp.
Maybe we can update the documentation to include an example using https://hexdocs.pm/ex_cldr_collation/Cldr.Collation.Insensitive.html for instance, WDYT?
from cmp.
Maybe we can update the documentation to include an example using https://hexdocs.pm/ex_cldr_collation/Cldr.Collation.Insensitive.html for instance, WDYT?
Good idea!
from cmp.
Related Issues (1)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cmp.