Giter Site home page Giter Site logo

Comments (5)

stevenaldinger avatar stevenaldinger commented on June 27, 2024

this fixes the panic: #15

from socketcluster-client-go.

gobliggg avatar gobliggg commented on June 27, 2024

@stevenaldinger: how do you fix this?

from socketcluster-client-go.

stevenaldinger avatar stevenaldinger commented on June 27, 2024

@gobliggg in scclient/parser/parser.go line 28: https://github.com/sacOO7/socketcluster-client-go/blob/master/scclient/parser/parser.go#L28

replace:

	itemsMap := message.(map[string]interface{})

with a check that the conversion is successful. keep in mind there's likely some deeper rooted issue that the conversion failed to begin with, but its still important to be catching errors like this. I'm not sure what appropriate error handling should be happening here, this just completely ignores the error instead of letting it panic:

	itemsMap, ok := message.(map[string]interface{})
	if !ok {
		return
	}

from socketcluster-client-go.

happilymarrieddad avatar happilymarrieddad commented on June 27, 2024

#16

from socketcluster-client-go.

happilymarrieddad avatar happilymarrieddad commented on June 27, 2024

Appears to be fixed in github.com/sacOO7/socketcluster-client-go v1.0.1-0.20230922063628-e06423a4ac46

from socketcluster-client-go.

Related Issues (10)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.