smb2_rename_async failed

[sahlberg]

smb2_rename_async failed

[afedchin]

use '\' in the path.
this should work

smb2_rename_async(smb2, "123\\abc.txt.tmp", "123\\abc.txt", smb2_rename_cb, NULL);

[sahlberg]

smb2_rename_async is buggy. Since this function tries to emulate posix it should
remap '/' to '' for you, but it doesn't.
Until I fix this bug you can use the workaround that @afedchin suggested.

smb2_unlink works as expected as does most other path paced calls since almost all calls will end up becomming a SMB2 Create + SMB2 + SMB2 close chain.

SMB2 Create does this remapping.

Rename is different since it uses a Set Info command to provide the new/old names.
This is why rename behaves differently to almost all other commands.

I will fix this bug in rename.
Thanks for testing and report.

[laoyur]

@afedchin thanks, it works !

url = smb2_parse_url(smb2, "smb://[email protected]/share/abc/123.txt");
url->path == "abc/123.txt"
why url->path not "abc\\123.txt" ? I don't understand it well.

[afedchin]

why url->path not "abc\123.txt" ? I don't understand it well.

because it's a path in an URL. SMB should use \ for paths. SMB path != URL path.

[laoyur]

ok, but why this works:

smb2_unlink(smb2, "123/abc.txt");

I just feel confused ...

[laoyur]

it seems like other apis accept /, but smb2_rename_async supports \ only ?

[amosavian]

82cce4a addressed this for open function.

[laoyur]

@sahlberg thanks :)
is there any chance to bring the sync version of rename ?

[sahlberg]

Please try current master. It contains a quick fix for the '/' vs '\' isssue. It also added a sync rename function. It compiles but has not been tested any furhter than that.

…

On Mon, Jun 4, 2018 at 10:44 AM, laoyur ***@***.***> wrote: @sahlberg <https://github.com/sahlberg> thanks :) is there any chance to bring the sync version of rename ? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#52 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAeNkMRV9VTYdLOu9Jn2LPJnqODjSfWsks5t5ILYgaJpZM4UXrm8> .

[laoyur]

Hi, I'm on iOS and currently using the pre-compiled lib from https://github.com/amosavian/AMSMB2
I've tried to build myself via the script provided within that project, but no luck
Your fix seems ok. I'll let you know later if I have time to make the build success.

[amosavian]

@laoyur please open an issue in AMSMB2 repository if you have any problem including failure to build.