Thumbnail crop should be higher

[saimn]

Thumbnail crop should be higher

[hyperking]

@reagle I was having the same issue and came up with this small hack that works for most images tall or stout. :-)

width, height = img.size img = img.crop( (0, -int(float(height/2)), width, height) )
you could add this code after line 116 in the image.py file. working on a way to specify the crop position in the config settings.

[saimn]

The img_processor setting can be used to specify the processor class. Pilkit provides several processors but it also possible to write a custom one (instead of hacking sigal's code ;-)) or inherit from a processor to modify its behavior.
http://pilkit.readthedocs.org/en/latest/#processors
https://github.com/matthewwithanm/pilkit/blob/master/pilkit/processors/resize.py
The default processor is ResizeToFit, but maybe SmartResize can give better results.
https://github.com/matthewwithanm/pilkit/blob/master/pilkit/processors/resize.py#L82

[hyperking]

@saimn looks simple. did you see my new feature request? could use some pointers
#82

[reagle]

SmartResize is hit or miss, makes some portraits better, others worse. I can't find evidence of pilkit detecting faces. @saimn which source file would you suggest a new class be added to?

[saimn]

@reagle you mean to add a new processor to sigal ? or a custom one ? In the first case, everything is in the image.py file, in the second case you add it directly in your config file.

[anarcat]

i would suggest closing this issue: yes, SmartResize is hit and miss, but there isn't much that can be done about this in Sigal itself. this is a pilkit problem, and should be reported there.

oh, and maybe this would be less of a problem if #315 was fixed...

[reagle]

SmartResize was one possible solution. I think it'd still make sense to adopt @hyperking's approach.

[saimn]

I realize now that an option was added in #263 to specify how thumbnails are cropped (the thumb_fit and thumb_fit_centering settings). This allows to crop from the top of the image, so I think the issue can be closed.

[saimn]

Oh, and just to clarify things, thumbnails are created directly with Pillow, so not using pilkit's processors:
https://github.com/saimn/sigal/blob/master/sigal/image.py#L139-L155

[reagle]

Ah, I had not noticed the thumb_fit_centering, thanks!