Inconsistent background inside floating windows

[tjgrhm]

Inconsistent background inside floating windows

[antoineco]

Good catch. I also noticed that on the Lazy screen.

Here is a reference to the commit which introduced the feature: 6510c08
If I remember correctly, it was introduced for NvimTree: #111 (comment).

We could probably re-visit this because

1. NvimTree has its own NvimTreeEndOfBuffer highlight group.
2. If I set :hi! link EndOfBuffer NonText (Neovim's default), everything seems to get displayed as expected.

[antoineco]

Before I push that change, here is a recap — with screenshots — of the way EndOfBuffer looks with a few settings variations.

While some cases below work flawlessly with a cleared EndOfBuffer background, others will have trade-off which users should be aware of.

---

show_eob:true dim_inactive:false

✅ Everything looks as expected

show_eob:true dim_inactive:false (current)

show_eob:true dim_inactive:false (clear EndOfBuffer bg)

---

show_eob:false dim_inactive:false

✅ Everything looks as expected

show_eob:false dim_inactive:false (current)

show_eob:false dim_inactive:false (clear EndOfBuffer bg)

---

show_eob:true dim_inactive:true

✅⚠️ The current appearance seems broken, with an entirely dimmed eob. I am not the author of the dimming feature, but to me this doesn't seem intentional, and I believe that the suggested change actually fixes it.

show_eob:true dim_inactive:true (current)

show_eob:true dim_inactive:true (clear EndOfBuffer bg)

---

show_eob:false dim_inactive:true

⚠️ Similarly to the above, the current appearance seems broken, with an entirely dimmed eob. In this case though, clearing the background color reveals the eob symbols in the current window, while keeping them hidden in inactive windows. I believe that this is an acceptable trade-off for having properly rendered floating windows everywhere. If need be, we can always revert the appearance (optimize for the active window instead) in a subsequent commit. (edit: addressed in 4eb1e19)

show_eob:false dim_inactive:true (current)

show_eob:false dim_inactive:true (clear EndOfBuffer bg)

---

Note
NvimTree's EndOfBuffer isn't affected by any of these: