Giter Site home page Giter Site logo

Comments (12)

sakithb avatar sakithb commented on May 28, 2024 2

I didn't have enough time and needed to add GNOME 41 support, so it will probably be the next update.

from media-controls.

sakithb avatar sakithb commented on May 28, 2024 1

Ok I will add this to the todo list. This will be in a later update.

from media-controls.

BruceWayne-Linux avatar BruceWayne-Linux commented on May 28, 2024

Is the ability to seek media added in new update ?

from media-controls.

BruceWayne-Linux avatar BruceWayne-Linux commented on May 28, 2024

it's ok bro

from media-controls.

sakithb avatar sakithb commented on May 28, 2024

WIP in seek-ft branch

from media-controls.

ChrisLauinger77 avatar ChrisLauinger77 commented on May 28, 2024

work in progress for main branch gnome 45
Bildschirmfoto vom 2023-10-17 23-54-30
this _ornament stuff does not work any more - need to find out how it can be done better ... @sakithb

from media-controls.

ChrisLauinger77 avatar ChrisLauinger77 commented on May 28, 2024

Bildschirmfoto vom 2023-10-18 00-29-53

have it working

from media-controls.

sakithb avatar sakithb commented on May 28, 2024

The ornament dots should be probably removed, I will do that in the meantime

You'll need to do some digging around in gnome code to get the ornament stuff right, besides they were slightly changed for gnome 45, since I've already done that for 44 I'll do that.

from media-controls.

ChrisLauinger77 avatar ChrisLauinger77 commented on May 28, 2024

Without my last change it would look like this:
grafik
I added the ornament.DOT and it looked better
line 701 player.js main
sliderContainer.setOrnament(PopupMenu.Ornament.DOT);

from media-controls.

sakithb avatar sakithb commented on May 28, 2024

The ornaments are kind of unnecessary in this context, let's keep this issue open until we figure out a workaround.

from media-controls.

ChrisLauinger77 avatar ChrisLauinger77 commented on May 28, 2024

I think my misstake was
this._infoItem.setOrnament(PopupMenu.Ornament.DOT);
line 583 player.js should be changed
I will test it in the evening. And add a screenshot here.
Will change to
this._infoItem.setOrnament(PopupMenu.Ornament.NONE);

from media-controls.

ChrisLauinger77 avatar ChrisLauinger77 commented on May 28, 2024

without the ornament.DOT on slider - the slider indicator looks like in my prev screenshot (flat not round)
Bildschirmfoto vom 2023-10-18 16-38-57
this is how it looks like in current commit in main @sakithb
It is not bothering me thb - not sure about U

from media-controls.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.